Merge pull request #6 from /issues/1-panic-logs-none

`panic()` should only log on secondary exceptions (fixes #1)

Author: hannes-ucsc

src/bd2k/util/exceptions.py

@@ -31,7 +31,7 @@ def __enter__( self ):
         self.exc_info = sys.exc_info( )
 
     def __exit__( self, *exc_info ):
-        if self.log is not None:
+        if self.log is not None and exc_info and exc_info[0]:
             self.log.warn( "Exception during panic", exc_info=exc_info )
         exc_type, exc_value, traceback = self.exc_info
         raise exc_type, exc_value, traceback

src/bd2k/util/test/test_panic.py

@@ -21,6 +21,12 @@ def test_panic( self ):
         except:
             self.__assert_raised_exception_is_primary( )
 
+    def test_panic_with_secondary( self ):
+        try:
+            self.try_and_panic_with_secondary( )
+        except:
+            self.__assert_raised_exception_is_primary( )
+
     def try_and_panic_by_hand( self ):
         try:
             self.line_of_primary_exc = inspect.currentframe( ).f_lineno + 1
@@ -34,6 +40,14 @@ def try_and_panic_by_hand( self ):
             raise exc_type, exc_value, exc_traceback
 
     def try_and_panic( self ):
+        try:
+            self.line_of_primary_exc = inspect.currentframe( ).f_lineno + 1
+            raise ValueError( "primary" )
+        except:
+            with panic( log ):
+                pass
+
+    def try_and_panic_with_secondary( self ):
         try:
             self.line_of_primary_exc = inspect.currentframe( ).f_lineno + 1
             raise ValueError( "primary" )