Skip to content

BI-2841 - Retrieve Germplasm Genotype Data Through DeltaBreed Samples#522

Merged
jloux-brapi merged 8 commits into
developfrom
feature/BI-2841
Jun 8, 2026
Merged

BI-2841 - Retrieve Germplasm Genotype Data Through DeltaBreed Samples#522
jloux-brapi merged 8 commits into
developfrom
feature/BI-2841

Conversation

@davedrp

@davedrp davedrp commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

BI-2841 - Retrieve Germplasm Genotype Data Through DeltaBreed Samples

Please include a summary of the change that was made.
Reflect the change of linking Genotypic Data to Germplasm via Genotype Samples instead of via Experiments

The main changes are in main/java/org/breedinginsight/services/geno/impl/GigwaGenotypeServiceImpl.java

  • modified the retrieveGenotypeData function.
  • Added the fetchGigwaSamples function.

In Support of those changes, modified BrAPISampleDAO.java

  • Exchanged the method readSamplesByIds with readSamplesByGermplasmIds.

Modified GigwaGenotypeServiceImplIntegrationTest.java

  • Re-enable testFetchGermplasmGenotype()

Dependencies

**bi-web:develop

Testing

  1. Import germplasm: germplasm ListHaps.xls
  2. Import Genotype Samples: bi_2839_sample_submission.xls
  3. Import Genotypic Data: you will have to ask me for this file. It will not allow this file type to be uploaded
  4. Go to a linked germpasm (such as GID=376).
  5. Click the Genotype tab
    THEN
    the Genotype data should appear on the screen below the Genotype tab.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit and/or integration tests to cover this change or tests are not applicable
  • I have commented my code, particularly in hard-to-understand areas
  • I have either updated the source of truth or arranged for update with product owner if needed https://breedinginsight.atlassian.net/wiki/spaces/BI/pages/1559953409/Source+of+Truth

@davedrp davedrp requested review from a team and jloux-brapi and removed request for a team June 2, 2026 16:27
@jloux-brapi

Copy link
Copy Markdown
Collaborator

Looks like build is failing after merging code from develop branch. Seems to be a unit test failure.

@nickpalladino

Copy link
Copy Markdown
Member

Looks like build is failing after merging code from develop branch. Seems to be a unit test failure.

Re-ran the github actions and all tests pass now, seems it was just a transient issue

Comment thread src/main/java/org/breedinginsight/utilities/BrAPIDAOUtil.java Outdated
@jloux-brapi jloux-brapi merged commit 0ca3bec into develop Jun 8, 2026
1 check passed
@jloux-brapi jloux-brapi deleted the feature/BI-2841 branch June 8, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants