BI-2848 - New Genotyping Page Backend: linkage to sample submission#523
Open
humsika wants to merge 6 commits into
Open
BI-2848 - New Genotyping Page Backend: linkage to sample submission#523humsika wants to merge 6 commits into
humsika wants to merge 6 commits into
Conversation
# Conflicts: # src/main/java/org/breedinginsight/services/geno/GenotypeService.java # src/main/java/org/breedinginsight/services/geno/impl/GigwaGenotypeServiceImpl.java # src/test/java/org/breedinginsight/services/geno/impl/GigwaGenotypeServiceImplIntegrationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2848
This change adds backend support for the new Genotyping page by linking successful genotype imports to sample submissions and exposing a new endpoint for the frontend.
Summary of changes made:
sample_submissionandimporter_importthrough the newgenotype_importjoin table/programs/{programId}/geno/importssampleSubmissionIdprojectNameForSampleSubmissionsampleSubmissionCreatedBygenotypingFileNamegenotypingImportDategenotypingImportByDependencies
genotype_importmust be appliedTesting
Validate the Backend/API by performing the following through manual testing:
genotype_importGET /v1/programs/{programId}/geno/importssampleSubmissionIdfor frontend linkingExample API checks:
GET /v1/programs/{programId}/geno/imports?page=1&pageSize=10GET /v1/programs/{programId}/geno/imports?page=1&pageSize=10&sortField=genotypingImportDate&sortOrder=DESCGET /v1/programs/{programId}/geno/imports?page=1&pageSize=10&projectNameForSampleSubmission=Sample1GET /v1/programs/{programId}/geno/imports?page=1&pageSize=10&genotypingFileName=vcfExpected behavior:
404dataresponseChecklist: