fix eob unit test and linting.

Author: JAMES FUQIAN

server/src/__tests__/server_test.ts

@@ -1,9 +1,6 @@
 import axios from "axios";
-import { getLoggedInUser } from '../utils/user';
-import db from '../utils/db';
 import app from '../Server';
 import * as reqs from '../utils/request';
-import AuthorizationToken from "../entities/AuthorizationToken";
 
 const BB2_BASE_URL = "https://sandbox.bluebutton.cms.gov";
 
@@ -23,20 +20,6 @@ const patient = { status: 200, data: { resource: "Patient" } };
 
 const profile = { status: 200, data: { resource: "Profile" } };
 
-const MOCK_AUTH_TOKEN_RESPONSE = {
-    status: 200,
-    data: {
-        access_token: "access_token_foo_refreshed",
-        expires_in: 36000,
-        token_type: "Bearer",
-        scope: ["scope1", "scope2", "scope3"],
-        refresh_token: "refresh_token_bar_refreshed",
-        patient: "-19990000000001",
-      },
-  };
-  
-const MOCK_AUTH_TOKEN = new AuthorizationToken(MOCK_AUTH_TOKEN_RESPONSE.data);
-
 let server: any;
 
 beforeAll(() => {
@@ -48,11 +31,12 @@ afterAll(() => {
 });
 
 test("expect patient end point returns patient data.", async () => {
+  jest.clearAllMocks();
   // mock patient returned at deeper layer
   jest.spyOn(reqs, 'get').mockImplementation((url) =>
     {
         if (url === BB2_PATIENT_URL) {
-          return Promise.resolve(patient);
+            return Promise.resolve(patient);
         } else {
             throw Error("Invalid end point URL: " + url);
         }
@@ -66,6 +50,7 @@ test("expect patient end point returns patient data.", async () => {
 });
 
 test("expect profile end point returns profile data.", async () => {
+  jest.clearAllMocks();
   // mock profile returned at lower level get
   jest.spyOn(reqs, 'get').mockImplementation((url) =>
     {
@@ -82,11 +67,12 @@ test("expect profile end point returns profile data.", async () => {
 });
 
 test("expect coverage end point returns coverage data.", async () => {
+    jest.clearAllMocks();
     // mock coverage returned at deeper layer
     jest.spyOn(reqs, 'get').mockImplementation((url) =>
         {
             if (url === BB2_COVERAGE_URL) {
-            return Promise.resolve(coverage);
+                return Promise.resolve(coverage);
             } else {
                 throw Error("Invalid end point URL: " + url);
             }
@@ -99,23 +85,20 @@ test("expect coverage end point returns coverage data.", async () => {
     expect(response.data).toEqual(coverage.data);
 });
 
-//test("expect eob end point returns eob data.", async () => {
-//    const loggedInUser = getLoggedInUser(db);
-//
-//    loggedInUser.authToken = MOCK_AUTH_TOKEN;
-//
-//    // mock eob returned at lower level get
-//    jest.spyOn(reqs, 'get').mockImplementation((url) =>
-//        {
-//          if (url === BB2_EOB_URL) {
-//            return Promise.resolve(eob);
-//          } else {
-//            throw Error("Invalid end point URL: " + url);
-//          }
-//        }
-//    );
-//
-//    const response = await axios.get("http://localhost:3003/api/data/benefit-direct");
-//    expect(response.status).toEqual(200);
-//    expect(response.data).toEqual(eob.data);
-//});
+test("expect eob end point returns eob data.", async () => {
+  jest.clearAllMocks();
+  // mock eob returned at lower level get
+  jest.spyOn(reqs, 'get').mockImplementation((url) =>
+       {
+         if (url === BB2_EOB_URL) {
+           return Promise.resolve(eob);
+         } else {
+            throw Error("Invalid end point URL: " + url);
+         }
+       }
+   );
+
+   const response = await axios.get("http://localhost:3003/api/data/benefit-direct");
+   expect(response.status).toEqual(200);
+   expect(response.data).toEqual(eob.data);
+});

server/src/configs/sample.config.ts

@@ -27,7 +27,9 @@ const config: ConfigType = {
     bb2BaseUrl: 'https://sandbox.bluebutton.cms.gov',
     bb2ClientId: '<client-id>',
     bb2ClientSecret: '<client-secret>',
-    bb2CallbackUrl: SELENIUM_TESTS ? 'http://server:3001/api/bluebutton/callback/' : 'http://localhost:3001/api/bluebutton/callback/',
+    bb2CallbackUrl: SELENIUM_TESTS ?
+    'http://server:3001/api/bluebutton/callback/' 
+    : 'http://localhost:3001/api/bluebutton/callback/',
   },
   local: {
     bb2BaseUrl: 'https://sandbox.bluebutton.cms.gov',

server/src/routes/Authorize.ts

@@ -76,7 +76,8 @@ export async function authorizationCallback(req: Request, res: Response) {
    * This is a hardcoded redirect, but this should be used from settings stored in a conf file
    * or other mechanism
    */
-  const fe_redirect_url = process.env.SELENIUM_TESTS ? 'http://client:3000' : 'http://localhost:3000';
+  const fe_redirect_url = 
+  process.env.SELENIUM_TESTS ? 'http://client:3000' : 'http://localhost:3000';
   res.redirect(fe_redirect_url);
 }
 

server/src/routes/Data.ts

@@ -1,7 +1,5 @@
 import { Router, Request, Response } from 'express';
-import moment from 'moment';
 import { getLoggedInUser } from '../utils/user';
-import { refreshAccessToken } from '../utils/bb2';
 import config from '../configs/config';
 import db from '../utils/db';
 import { get } from '../utils/request';
@@ -22,25 +20,11 @@ function getURL(path: string): string {
 // user and returned - we are then storing in a mocked DB
 export async function getBenefitData(req: Request, res: Response) {
   const loggedInUser = getLoggedInUser(db);
-  const FHIR_EOB_PATH = 'fhir/ExplanationOfBenefit/';
-  const BB2_BENEFIT_URL = getURL(FHIR_EOB_PATH);
-
-  
-  if (!loggedInUser.authToken || !loggedInUser.authToken.accessToken) {
-    return { data: {} };
-  }
-
-  /*
-  * If the access token is expired, use the refresh token to generate a new one
-  */
-  if (moment(loggedInUser.authToken.expiresAt).isBefore(moment())) {
-    const newAuthToken = await refreshAccessToken(loggedInUser.authToken.refreshToken);
-    loggedInUser.authToken = newAuthToken;
-  }
-
-  const response = await get(BB2_BENEFIT_URL, req.query, `${loggedInUser.authToken?.accessToken}`);
-
-  return response.data as Record<string, unknown>;
+  // get EOB end point
+  const response = await get(getURL('fhir/ExplanationOfBenefit/'),
+                             req.query,
+                             `${loggedInUser.authToken?.accessToken || 'no access token'}`);
+  res.json(response.data);
 }
 
 /*