update client browser db, code cleanup, use logger vs console log.

Author: James Fuqian

client/yarn.lock

@@ -3224,9 +3224,9 @@ caniuse-api@^3.0.0:
     lodash.uniq "^4.5.0"
 
 caniuse-lite@^1.0.0, caniuse-lite@^1.0.30000981, caniuse-lite@^1.0.30001109, caniuse-lite@^1.0.30001125, caniuse-lite@^1.0.30001181:
-  version "1.0.30001191"
-  resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001191.tgz#bacb432b6701f690c8c5f7c680166b9a9f0843d9"
-  integrity sha512-xJJqzyd+7GCJXkcoBiQ1GuxEiOBCLQ0aVW9HMekifZsAVGdj5eJ4mFB9fEhSHipq9IOk/QXFJUiIr9lZT+EsGw==
+  version "1.0.30001279"
+  resolved "https://registry.npmjs.org/caniuse-lite/-/caniuse-lite-1.0.30001279.tgz"
+  integrity sha512-VfEHpzHEXj6/CxggTwSFoZBBYGQfQv9Cf42KPlO79sWXCD1QNKWKsKzFeWL7QpZHJQYAvocqV6Rty1yJMkqWLQ==
 
 capture-exit@^2.0.0:
   version "2.0.0"

server/src/routes/Authorize.ts

@@ -6,7 +6,7 @@ import db from '../utils/db';
 import { getAccessToken, generateAuthorizeUrl } from '../utils/bb2';
 import { getBenefitData } from './Data';
 import { getLoggedInUser } from 'src/utils/user';
-
+import logger from '@shared/Logger';
 
 export async function authorizationCallback(req: Request, res: Response) {
     try {
@@ -52,6 +52,7 @@ export async function authorizationCallback(req: Request, res: Response) {
         * to display or store the error
          */
         console.log(e);
+        logger.info(e)
     }
         /* DEVELOPER NOTE:
          * This is a hardcoded redirect, but this should be used from settings stored in a conf file

server/src/utils/call.ts

@@ -2,6 +2,7 @@ import axios from 'axios';
 import FormData from 'form-data';
 import { try_later } from './queue';
 import { is_retryable } from './retry';
+import logger from '@shared/Logger';
 
 export async function endpointPost(endpoint_url: string, data: FormData, extra: any) {
     return await httpCall({ 
@@ -25,42 +26,37 @@ export async function httpCall(config: any, retry_flag: boolean) {
     var resp = null
     try {
         resp = await axios(config);
-        console.log("<<<<<<<<<<<<<<<<<<< RESPONSE:")
-        console.log(resp.data);
-        console.log(">>>>>>>>>>>>>>>>>>>>>>>>>>>>>")
+        logger.info("RESPONSE:")
+        logger.info(resp.data);
     } catch (error: any) {
         // DEVELOPER NOTES:
         // here handle errors per errors.readme.md
         if (error.response) {
-            console.log("<<<<<<<<<<<<<<<<<<<<<< ERROR RESPONSE:")
-            console.log(error.response.status)
-            console.log(error.response.data)
+            logger.info("ERROR RESPONSE:")
+            logger.info(error.response.status)
+            logger.info(error.response.data)
             resp = error.response
-            console.log(">>>>>>>>>>>>>>>>>>>>>>>>")
             // DEVELOPER NOTES:
             // check for retryable (500) errors and enqueue it for retry
             if (retry_flag && is_retryable(error)) {
                 try_later(error);
-                console.log("Request failed and is retryable, saved for retry later.")
+                logger.info("Request failed and is retryable, saved for retry later.")
             }
         }
         else if (error.request) {
             // something went wrong on sender side, not retryable
             // error.request is an instance of XMLHttpRequest in the browser and an instance of
             // http.ClientRequest in node.js
-            console.log("<<<<<<<<<<<<<<<<<<<<<< ERROR REQUEST:")
-            console.log(error.request);
-            console.log(">>>>>>>>>>>>>>>>>>>>>>>>")
+            logger.info("ERROR REQUEST:")
+            logger.info(error.request);
         }
         else {
-            console.log("<<<<<<<<<<<<<<<<<<<<<<<< OTHER ERRORS:")
-            console.log('Error: [', error.message, ']');
-            console.log(">>>>>>>>>>>>>>>>>>>>>>>>")
+            logger.info("OTHER ERRORS:")
+            logger.info('Error: [' + error.message + ']');
         }
         // dump axios config for diagnosis
-        console.log("----------------- CONFIG:")
-        console.log(error.config);
-        console.log("-------------------------")
+        logger.info("CONFIG:")
+        logger.info(error.config);
     }
     return resp    
 }

server/src/utils/queue.ts

@@ -31,7 +31,6 @@ export default class Retryables<T> implements IQueue<T> {
 const RetryableRequests = new Retryables<Retryable>();
 
 export function try_later(item: any) {
-    console.log("try_later() called: ", item)
     RetryableRequests.enQ(new Retryable(item, 3));
 }
 

server/src/utils/retry.ts

@@ -1,5 +1,6 @@
 import * as cron from 'node-cron'
 import { do_retry } from './queue';
+import logger from '@shared/Logger';
 
 // schedule cron job
 export function schedule() {
@@ -40,22 +41,17 @@ export default class Retryable {
             // hard code back off by minutes
             var next_retry_time = new Date(this.created.getTime() + (60000 * (2 ** this.count)))
             var current_time = new Date()
-            console.log("next retry at: ", next_retry_time, ", current time: ", current_time)
             is_ready = current_time > next_retry_time;
-            console.log("is_ready: ", is_ready)
         }
         return is_ready;
     }
 
     tried() {
-        console.log("count=", this.count)
         this.count=this.count + 1;
-        console.log("after count=", this.count)
         return !this.expired();
     }
 
     expired() {
-        console.log("expired ? max=", this.max, ", count=", this.count, " max = count? :", (this.max - this.count) === 0)
         return (this.max - this.count) === 0;
     }
 }