address feedback.

Author: James Fuqian

README.md

@@ -81,4 +81,6 @@ Both ways of starting the sample are running the sample in foreground, logging a
 
 For client and server started separately in their command window, type Ctrl C respectively
 
-
+Error Responses and handling:
+-----------------------------
+[See ErrorResponses.md](./ErrorResponses.md)

client/src/components/records.tsx

@@ -13,7 +13,7 @@ export type ErrorResponse = {
     content: string,
 }
 
-export default function Records({ }) {
+export default function Records() {
     const [records, setRecords] = useState<EOBRecord[]>([]);
     const [message, setMessage] = useState<ErrorResponse>();
     /*

server/package.json

@@ -5,6 +5,7 @@
     "build": "./node_modules/.bin/ts-node build.ts",
     "lint": "eslint . --ext .ts",
     "start": "node -r module-alias/register ./dist --env=production",
+    "start:debug": "node --inspect=0.0.0.0:9229 ./node_modules/.bin/ts-node -r tsconfig-paths/register ./src",
     "start:dev": "nodemon",
     "test": "nodemon --config ./spec/nodemon.json"
   },

server/src/routes/Authorize.ts

@@ -69,8 +69,7 @@ export async function authorizationCallback(req: Request, res: Response) {
         * This is where you could also use a data service or other exception handling
         * to display or store the error
          */
-        console.log(e);
-        logger.info(e)
+        logger.err(e)
     }
         /* DEVELOPER NOTE:
          * This is a hardcoded redirect, but this should be used from settings stored in a conf file

server/src/utils/request.ts

@@ -1,5 +1,6 @@
 import axios from 'axios';
 import FormData from 'form-data';
+import logger from '@shared/Logger';
 
 export async function post(endpoint_url: string, data: FormData, headers: any) {
     return await request({ 
@@ -30,14 +31,14 @@ export async function request(config: any, retryFlag: boolean) {
     } catch (error: any) {
         // DEVELOPER NOTES:
         // here handle errors per ErrorResponses.md
-        console.log('Error message: [', error.message, ']');
+        logger.info('Error message: [' + error.message + ']');
         if (error.response) {
-            console.log("response code: " + error.response.status)
-            console.log("response text: " + JSON.stringify(error.response.data))
+            logger.info("response code: " + error.response.status)
+            logger.info("response text: " + JSON.stringify(error.response.data))
             // DEVELOPER NOTES:
             // check for retryable (e.g. 500 & fhir) errors and do retrying...
             if (retryFlag && isRetryable(error)) {
-                console.log("Request failed and is retryable, entering retry process...")
+                logger.info("Request failed and is retryable, entering retry process...")
                 var retryResp = await do_retry(config)
                 if (retryResp) {
                     resp = retryResp;
@@ -51,11 +52,8 @@ export async function request(config: any, retryFlag: boolean) {
             // something went wrong on sender side, not retryable
             // error.request is an instance of XMLHttpRequest in the browser and an instance of
             // http.ClientRequest in node.js
-            console.log("error.request: " + error.request);
+            logger.info("error.request: " + error.request);
         }
-        // dump axios config for diagnosis
-        // console.log("config:")
-        // console.log(error.config);
     }
     return resp    
 }
@@ -77,19 +75,19 @@ async function do_retry(config: any) {
     var resp = null
     for (let i = 0; i < max_attempts; i++) {
         var wait_in_sec = interval * (2 ** i)
-        console.log("wait ", wait_in_sec, " seconds...")
+        logger.info("wait " + wait_in_sec + " seconds...")
         await sleep(wait_in_sec * 1000)
-        console.log("retry attempts: ", i+1)
+        logger.info("retry attempts: " + (i+1))
         try {
             resp = await axios(config);
-            console.log("retry successful:")
-            console.log(resp.data);
+            logger.info("retry successful:")
+            logger.info(resp.data);
             break;
         } catch (error: any) {
-            console.log("retry error: [", JSON.stringify(error.message), "]")
+            logger.info("retry error: [" + JSON.stringify(error.message) + "]")
             if (error.response) {
-                console.log("response code: ", error.response.status)
-                console.log("response data: ", error.response.data)
+                logger.info("response code: " + error.response.status)
+                logger.info("response data: " + error.response.data)
                 resp = error.response
             }
         }