Skip to content

Commit 7d1970b

Browse files
author
JAMES FUQIAN
committed
add PR template.
1 parent 6b933dc commit 7d1970b

2 files changed

Lines changed: 67 additions & 20 deletions

File tree

.github/pull_request_template.md

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
<!--
2+
You've got a Pull Request you want to submit? Awesome!
3+
This PR template is here to help ensure you're setup for success:
4+
please fill it out to help ensure that your PR is complete and ready for approval.
5+
-->
6+
7+
**JIRA Ticket:**
8+
[SOMEPROJECT-42](https://jira.cms.gov/browse/SOMEPROJECT-42)
9+
10+
**User Story or Bug Summary:**
11+
12+
<!-- Please copy-paste the brief user story or bug description that this PR is intended to address. -->
13+
14+
### What Does This PR Do?
15+
16+
<!--
17+
Add detailed description & discussion of changes here.
18+
The contents of this section should be used as your commit message (unless you merge the PR via a merge commit, of course).
19+
20+
Please follow standard Git commit message guidelines:
21+
* First line should be a capitalized, short (50 chars or less) summary.
22+
* The rest of the message should be in standard Markdown format, wrapped to 72 characters.
23+
* Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.
24+
* List all relevant Jira issue keys, one per line at the end of the message, per: <https://confluence.atlassian.com/jirasoftwarecloud/processing-issues-with-smart-commits-788960027.html>.
25+
26+
Reference: <https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project>.
27+
-->
28+
29+
### What Should Reviewers Watch For?
30+
31+
<!--
32+
Add some items to the following list, or remove the entire section if it doesn't apply for some reason.
33+
34+
Common items include:
35+
* Is this likely to address the goals expressed in the user story?
36+
* Are any additional documentation updates needed?
37+
* Are there any unhandled and/or untested edge cases you can think of?
38+
* Is user input properly sanitized & handled?
39+
* Does this make any backwards-incompatible changes that might break end user clients?
40+
* Can you find any bugs if you run the code locally and test it manually?
41+
-->
42+
43+
If you're reviewing this PR, please check these things, in particular:
44+
45+
- TODO

server/src/data/Database.py

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,28 +7,28 @@
77
"""
88

99
basicAuthToken = {
10-
'access_token' : '',
11-
'expires_in' : 0,
12-
'expires_at' : 0,
13-
'token_type' : '',
14-
'scope' : '',
15-
'refresh_token' : '',
16-
'patient' : ''
10+
'access_token': '',
11+
'expires_in': 0,
12+
'expires_at': 0,
13+
'token_type': '',
14+
'scope': '',
15+
'refresh_token': '',
16+
'patient': ''
1717
}
1818

1919
basicUser = {
20-
'authToken' : basicAuthToken,
21-
'name' : '',
22-
'userName' : '',
23-
'pcp' : '',
24-
'primaryFacility' : '',
25-
'eobData' : {}
20+
'authToken': basicAuthToken,
21+
'name': '',
22+
'userName': '',
23+
'pcp': '',
24+
'primaryFacility': '',
25+
'eobData': {}
2626
}
2727

2828
DBusers = [basicUser]
29-
DBsettings = Settings('','','')
30-
DBcodeChallenge = dict['codeChallenge' : '','verifier' : '']
31-
DBcodeChallenges = {'' : DBcodeChallenge}
29+
DBsettings = Settings('', '', '')
30+
DBcodeChallenge = dict['codeChallenge': '','verifier': '']
31+
DBcodeChallenges = {'': DBcodeChallenge}
3232
DBid = 1
3333

3434
"""
@@ -46,11 +46,13 @@
4646
* we are expecting this user to be linked to the
4747
* BB2 Sandbox User BBUser29999 or BBUser29998
4848
"""
49+
50+
4951
def initDB():
5052

5153
sampleUser = basicUser
52-
sampleUser.update({'name':'John Doe'})
53-
sampleUser.update({'username':'jdoe29999'})
54-
sampleUser.update({'pcp':'Dr. Hibbert'})
55-
sampleUser.update({'primaryFacility':'Springfield General Hospital'})
54+
sampleUser.update({'name': 'John Doe'})
55+
sampleUser.update({'username': 'jdoe29999'})
56+
sampleUser.update({'pcp': 'Dr. Hibbert'})
57+
sampleUser.update({'primaryFacility': 'Springfield General Hospital'})
5658
DBusers.append(sampleUser)

0 commit comments

Comments
 (0)