refactor: use collection id in download search_by_id (#44)

use the collection id coming from the download request in the
search_by_id sent to the eodag server to avoid having search metrics
with the eodag product type

Author: jlahovnik

stac_fastapi/eodag/extensions/data_download.py

@@ -107,17 +107,17 @@ def get_data(
 
         # check if the collection is known
         try:
-            product_type = dag.get_product_type_from_alias(collection_id)
+            dag.get_product_type_from_alias(collection_id)
         except NoMatchingProductType as e:
             raise NotFoundError(e) from e
 
-        search_results = dag.search(id=item_id, productType=product_type, provider=federation_backend)
+        search_results = dag.search(id=item_id, productType=collection_id, provider=federation_backend)
         if len(search_results) > 0:
             product = cast(EOProduct, search_results[0])
 
         else:
             raise NotFoundError(
-                f"Could not find {item_id} item in {product_type} collection",
+                f"Could not find {item_id} item in {collection_id} collection",
                 f" for backend {federation_backend}.",
             )