fix: remove providers in items and collections (#6)

Providers are not a required field in STAC spec.

Besides, what we currently have in EODAG is the backend which is already
set in federation:backend field.
The added value would be to have providers with roles such as producer,
licensor or processor, but it is not yet possible with EODAG

Signed-off-by: Aubin Lambaré <aubin.lambare@cs-soprasteria.com>

Author: alambare

stac_fastapi/eodag/landing_page.py stac_fastapi/eodag/client.pystac_fastapi/eodag/landing_page.py renamed to stac_fastapi/eodag/client.py

@@ -47,10 +47,10 @@
 from eodag.plugins.search.build_search_result import ECMWFSearch
 from eodag.utils import deepcopy, get_geometry_from_various
 from eodag.utils.exceptions import NoMatchingProductType as EodagNoMatchingProductType
+from stac_fastapi.eodag.client import CustomCoreClient
 from stac_fastapi.eodag.config import get_settings
 from stac_fastapi.eodag.cql_evaluate import EodagEvaluator
 from stac_fastapi.eodag.errors import NoMatchingProductType, ResponseSearchError
-from stac_fastapi.eodag.landing_page import CustomCoreClient
 from stac_fastapi.eodag.models.links import (
     CollectionLinks,
     ItemCollectionLinks,
@@ -59,9 +59,7 @@
 from stac_fastapi.eodag.models.stac_metadata import (
     CommonStacMetadata,
     create_stac_item,
-    get_provider_dict,
     get_sortby_to_post,
-    merge_providers,
 )
 from stac_fastapi.eodag.utils import (
     dt_range_to_eodag,
@@ -153,10 +151,6 @@ def has_ecmwf_search_plugin(federation_backends, request):
             request=request,
         ).get_links(extensions=extension_names, extra_links=product_type.get("links", []) + collection.get("links", []))
 
-        collection["providers"] = merge_providers(
-            collection.get("providers", []) + [get_provider_dict(request, fb) for fb in federation_backends]
-        )
-
         return collection
 
     def _search_base(self, search_request: BaseSearchPostRequest, request: Request) -> ItemCollection:

stac_fastapi/eodag/core.py

@@ -222,24 +222,6 @@ def create_stac_metadata_model(
     return model
 
 
-def get_provider_dict(request: Request, provider: str) -> dict[str, Any]:
-    """Generate STAC provider dict
-
-    :param request: FastAPI request
-    :param provider: provider name
-    :return: Provider dictionary
-    """
-    provider_config = next(
-        p for p in request.app.state.dag.providers_config.values() if provider in [p.name, getattr(p, "group", None)]
-    )
-    return {
-        "name": getattr(provider_config, "group", provider_config.name),
-        "description": getattr(provider_config, "description", None),
-        "roles": getattr(provider_config, "roles", None),
-        "url": getattr(provider_config, "url", None),
-    }
-
-
 def get_federation_backend_dict(request: Request, provider: str) -> dict[str, Any]:
     """Generate Federation backend dict
 
@@ -257,27 +239,6 @@ def get_federation_backend_dict(request: Request, provider: str) -> dict[str, An
     }
 
 
-def merge_providers(provider_list: list[dict[str, Any]]) -> list[dict[str, Any]]:
-    """Merges a list of provider dictionaries, combining roles for duplicate names while keeping original properties.
-
-    :param provider_list: list of provider dictionaries
-    :return: list of merged provider dictionaries
-    """
-    merged_providers: dict[str, dict[str, Any]] = {}
-
-    for provider in provider_list:
-        name = provider["name"]
-
-        if merged := merged_providers.get("name"):
-            m_roles = set(merged[name].get("roles", []))
-            m_roles.update(set(provider.get("roles", [])))
-            merged[name]["roles"] = list(m_roles)
-        else:
-            merged_providers[name] = provider
-
-    return list(merged_providers.values())
-
-
 def create_stac_item(
     product: EOProduct,
     model: type[CommonStacMetadata],
@@ -362,13 +323,7 @@ def create_stac_item(
                     },
                 }
 
-    provider_dict = get_provider_dict(request, product.provider)
-    feature_model = model.model_validate(
-        {
-            **product.properties,
-            **{"federation:backends": [product.provider], "providers": [provider_dict]},
-        }
-    )
+    feature_model = model.model_validate({**product.properties, **{"federation:backends": [product.provider]}})
     stac_extensions.update(feature_model.get_conformance_classes())
 
     feature["properties"] = feature_model.model_dump(exclude_none=True, exclude=ITEM_PROPERTIES_EXCLUDE)

stac_fastapi/eodag/extensions/datacube_download.py

@@ -33,7 +33,6 @@ async def test_collection(
     assert result["id"] == defaults.product_type
     assert all(isinstance(v, list) for v in result["summaries"].values())
     assert len(result["summaries"]["federation:backends"]) > 0
-    assert len(result["providers"]) > 0
     for link in result["links"]:
         assert link["rel"] in ["self", "items", "http://www.opengis.net/def/rel/ogc/1.0/queryables"]
 

stac_fastapi/eodag/models/stac_metadata.py

@@ -76,14 +76,6 @@ async def test_items_response(request_valid, defaults):
         "geometry",
         "properties",
     }
-    assert len(first_props["providers"]) == 1
-    assert first_props["providers"][0] == {
-        "name": "peps",
-        "description": ANY,
-        "roles": ["host"],
-        "url": "https://peps.cnes.fr",
-    }
-    assert "id" not in first_props
     assert first_props["federation:backends"] == ["peps"]
     assert first_props["datetime"] == "2018-02-15T23:53:22.871Z"
     assert first_props["start_datetime"] == "2018-02-15T23:53:22.871Z"