fix: set server logging (#36)

also truncate too long logs

Author: alambare

stac_fastapi/eodag/core.py

@@ -81,7 +81,7 @@
     NumType = Union[float, int]
 
 
-logger = logging.getLogger()
+logger = logging.getLogger(__name__)
 
 loop = asyncio.get_event_loop()
 

stac_fastapi/eodag/errors.py

@@ -62,7 +62,7 @@
     RequestError: status.HTTP_400_BAD_REQUEST,
 }
 
-logger = logging.getLogger("eodag.rest.server")
+logger = logging.getLogger(__name__)
 
 
 def exception_handler_factory(status_code: int):
@@ -93,24 +93,14 @@ class ResponseSearchError(Exception):
 
     _alias_to_field_cache: dict[str, str] = {}
 
+    errors: list[SearchError]
+
     def __init__(self, errors: list[tuple[str, Exception]], stac_metadata_model: type[BaseModel]) -> None:
         """Initialize error response class."""
         self._errors = errors
         self._stac_medatata_model = stac_metadata_model
 
-    def _eodag_to_stac(self, value: str) -> str:
-        """Convert EODAG name to STAC."""
-        if not self._alias_to_field_cache:
-            self._alias_to_field_cache = {
-                field.alias or str(field.validation_alias): name
-                for name, field in self._stac_medatata_model.model_fields.items()
-            }
-        return self._alias_to_field_cache.get(value, value)
-
-    @property
-    def errors(self) -> list[SearchError]:
-        """Return errors."""
-        errors: list[SearchError] = []
+        self.errors = []
         for name, exc in self._errors:
             error: SearchError = {
                 "provider": name,
@@ -135,14 +125,21 @@ def errors(self) -> list[SearchError]:
                     stac_param = self._eodag_to_stac(error_param)
                     error["message"] = error["message"].replace(error_param, stac_param)
 
-            errors.append(error)
+            self.errors.append(error)
 
-        return errors
+    def _eodag_to_stac(self, value: str) -> str:
+        """Convert EODAG name to STAC."""
+        if not self._alias_to_field_cache:
+            self._alias_to_field_cache = {
+                field.alias or str(field.validation_alias): name
+                for name, field in self._stac_medatata_model.model_fields.items()
+            }
+        return self._alias_to_field_cache.get(value, value)
 
     @property
     def status_code(self) -> int:
         """Get global errors status code."""
-        if len(self._errors) == 1:
+        if len(self.errors) == 1:
             return self.errors[0]["status_code"]
 
         return 400

stac_fastapi/eodag/logs.py

@@ -66,17 +66,27 @@ async def dispatch(self, request, call_next):
 class CustomFormatter(logging.Formatter):
     """custom logging formatter"""
 
+    def alias_logger_name(self, name: str) -> str:
+        """Replace logger name prefix with alias 'stac_eodag' if it starts with 'stac_fastapi.eodag'."""
+        prefix = "stac_fastapi.eodag"
+        alias = "stac_eodag"
+        if name.startswith(prefix):
+            name = alias + name[len(prefix) :]
+
+        name = name.replace(".extensions.", ".ext.")
+        return name
+
     def format(self, record):
         """Add a unique log ID and
         custom timestamp in the log output."""
         request_id = request_id_context.get()
         if request_id == "None":
-            request_id = uuid.uuid4().hex[:8]
+            request_id = ""
         timestamp = datetime.now().strftime("%Y-%m-%d %H:%M:%S")
-        logger_name = record.name
+        logger_name = self.alias_logger_name(record.name)
         log_message = super().format(record)
 
-        log_message = f"{timestamp} {logger_name:<32} [{record.levelname:<8}] [{request_id}] {log_message}"
+        log_message = f"{timestamp} {logger_name:<32} [{record.levelname:<8}] [{request_id:<8}] {log_message}"
 
         return log_message
 
@@ -85,10 +95,18 @@ def init_logging():
     """Initialize the logging configuration"""
     settings = get_settings()
 
+    log_level = logging.DEBUG if settings.debug else logging.INFO
+
     setup_logging(3 if settings.debug else 2, no_progress_bar=True)
 
     custom_formatter = CustomFormatter()
 
+    logging.basicConfig(level=log_level)
+    for handler in logging.getLogger().handlers:
+        handler.setFormatter(custom_formatter)
+
+    logging.getLogger("eodag").propagate = False
+
     for logger_name in ("eodag", "uvicorn", "uvicorn.access"):
         logger = logging.getLogger(logger_name)
         for handler in logger.handlers:

stac_fastapi/eodag/telemetry.py

@@ -46,7 +46,7 @@
     from eodag import EODataAccessGateway
 
 
-logger = logging.getLogger("eodag.rest.utils.observability")
+logger = logging.getLogger(__name__)
 
 
 def create_tracer_provider(resource: Resource) -> Union[TracerProvider, trace.TracerProvider]: