fix: Fixed free-text search (#48)

Even though `stac-fastapi-eodag` defined the `q` parameter as an
optional string in `all_collections`, this seems to be ignored by
fastapi since the `q` is defined by the module `stac-fastapi` on the
free_text extension as a list of strings.

This requires the `q` parameter to be expanded, using AND by default,
which can be parsed by the eodag free-text parser.

---------

Co-authored-by: Guillermo Tesoro Calvo <guillermo.tesoro@c-ssystems.de>

Author: gtesoro

stac_fastapi/eodag/core.py

@@ -95,6 +95,7 @@ class EodagCoreClient(CustomCoreClient):
 
     def _get_collection(self, product_type: dict[str, Any], request: Request) -> Collection:
         """Convert a EODAG produt type to a STAC collection."""
+
         collection = Collection(deepcopy(request.app.state.ext_stac_collections.get(product_type["ID"], {})))
 
         platform_value = [p for p in (product_type.get("platformSerialIdentifier") or "").split(",") if p]
@@ -224,7 +225,7 @@ async def all_collections(
         datetime: Optional[str] = None,
         limit: Optional[int] = 10,
         offset: Optional[int] = 0,
-        q: Optional[str] = None,
+        q: Optional[list[str]] = None,
         query: Optional[str] = None,
     ) -> Collections:
         """
@@ -260,9 +261,13 @@ async def all_collections(
         if any((q, datetime)):
             start, end = dt_range_to_eodag(str_to_interval(datetime))
 
+            # q is always a list, per stac-api free_text extension definiton
+            # Expanding with AND as default.
+            free_text = " AND ".join(q or [])
+
             try:
                 guessed_product_types = request.app.state.dag.guess_product_type(
-                    free_text=q, missionStartDate=start, missionEndDate=end
+                    free_text=free_text, missionStartDate=start, missionEndDate=end
                 )
             except EodagNoMatchingProductType:
                 product_types = []

tests/test_collections.py

@@ -76,7 +76,7 @@ async def test_search_collections_freetext_ok(app_client, mock_list_product_type
     r = await app_client.get("/collections?q=TERM1,TERM2")
     assert mock_list_product_types.called
     mock_guess_product_type.assert_called_once_with(
-        free_text=["TERM1", "TERM2"], missionStartDate=None, missionEndDate=None
+        free_text="TERM1 AND TERM2", missionStartDate=None, missionEndDate=None
     )
     assert r.status_code == 200
     assert ["S2_MSI_L1C"] == [col["id"] for col in r.json().get("collections", [])]
@@ -146,7 +146,7 @@ async def test_search_collections_datetime(app_client, mock_list_product_types,
     r = await app_client.get(f"/collections?datetime={start}/{end}")
 
     assert mock_list_product_types.called
-    mock_guess_product_type.assert_called_once_with(free_text=None, missionStartDate=start, missionEndDate=end)
+    mock_guess_product_type.assert_called_once_with(free_text="", missionStartDate=start, missionEndDate=end)
     assert r.status_code == 200
     assert ["S2_MSI_L1C"] == [col["id"] for col in r.json().get("collections", [])]