fix: milliseconds precision in dates and tests update (#90)

- use milliseconds precision for items dates
- update tests following STAC-formatted serialization in EODAG
- improve tests failures verbosity

Author: sbrunato

stac_fastapi/eodag/models/stac_metadata.py

@@ -64,8 +64,9 @@ class CommonStacMetadata(ItemProperties):
 
     @field_serializer("datetime", "start_datetime", "end_datetime", "created", "updated")
     def format_datetime(self, value: dt):
-        """format datetime properties"""
-        return value.strftime("%Y-%m-%dT%H:%M:%S.%fZ")
+        """format datetime properties with milliseconds precision (3 decimal places)"""
+        milliseconds = value.microsecond // 1000
+        return value.strftime("%Y-%m-%dT%H:%M:%S") + f".{milliseconds:03d}Z"
 
     @model_validator(mode="before")
     @classmethod

tests/conftest.py

@@ -169,7 +169,7 @@ def mock_search_result():
                             "https://peps.cnes.fr/resto/collections/S1/578f1768-e66e-5b86-9363-b19f8931cc7b/download"
                         ),
                         "eodag:provider": "peps",
-                        "eodag:collection": "S1_SAR_OCN",
+                        "collection": "S1_SAR_OCN",
                         "platform": "S1A",
                         "eo:cloud_cover": 0,
                         "title": "S1A_WV_OCN__2SSV_20180215T235323_20180216T001213_020624_023501_0FD3",
@@ -226,7 +226,7 @@ def mock_search_result():
                             "https://peps.cnes.fr/resto/collections/S1/578f1768-e66e-5b86-9363-b19f8931cc7c/download"
                         ),
                         "eodag:provider": "peps",
-                        "eodag:collection": "S1_SAR_OCN",
+                        "collection": "S1_SAR_OCN",
                         "platform": "S1A",
                         "eo:cloud_cover": 0,
                         "title": "S1A_WV_OCN__2SSV_20180216T235323_20180217T001213_020624_023501_0FD3",
@@ -450,7 +450,7 @@ async def _request_valid_raw(
                 pytest.fail(f"Assertion failed: {e}\nAdditional context: {response.text}.")
 
         assert expected_status_code == response.status_code, (
-            f"For {method}: {url}, body: {post_data}, got: {str(response)}"
+            f"For {method}: {url}, body: {post_data}, got: {response.content}"
         )
         return response
 

tests/test_search.py

@@ -126,9 +126,9 @@ async def test_items_response(request_valid, defaults):
         "properties",
     }
     assert first_props["federation:backends"] == ["peps"]
-    assert first_props["datetime"] == "2018-02-15T23:53:22.871000Z"
-    assert first_props["start_datetime"] == "2018-02-15T23:53:22.871000Z"
-    assert first_props["end_datetime"] == "2018-02-16T00:12:14.035000Z"
+    assert first_props["datetime"] == "2018-02-15T23:53:22.871Z"
+    assert first_props["start_datetime"] == "2018-02-15T23:53:22.871Z"
+    assert first_props["end_datetime"] == "2018-02-16T00:12:14.035Z"
     assert first_props["license"] == "other"
     assert first_props["platform"] == "S1A"
     assert first_props["instruments"] == ["SAR-C", "SAR"]