fix(upgrade): re-register is_device_in_maintenance hook against includes/functions.php

plugin_maint_install() registers the hook with the relocated includes/functions.php path, but install never re-runs on upgrade and core's api_plugin_upgrade_register() only touches plugin_config, never plugin_hooks. Existing installs therefore keep the stale functions.php hook file. Re-register the hook in plugin_maint_check_upgrade()'s version-change branch so upgraded sites pick up the new path (currently only surviving via the back-compat root shim). Assert the repoint in MaintCheckUpgradeTest.

Author: Copilot

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 --- develop ---
 
-* refactor: Move schema management into includes/database.php (the thold model) and relocate functions.php into includes/; setup.php delegates via require_once, and plugin_maint_check_upgrade() now refreshes the schema via db_update_table() and updates the full plugin_config row on a version change. Switches every file inclusion from include/include_once to require/require_once
+* refactor: Move schema management into includes/database.php (the thold model) and relocate functions.php into includes/; setup.php delegates via require_once, and plugin_maint_check_upgrade() now refreshes the schema via db_update_table(), re-registers the is_device_in_maintenance hook against includes/functions.php, and updates the full plugin_config row on a version change. Switches every file inclusion from include/include_once to require/require_once
 * dev: Enforce patch coverage of changed lines in CI and remove the inert COMPOSER_ROOT_VERSION env from the Pest step
 * feature: Add a standard Cacti search filter to the Maintenance Schedules list that also matches the hostname/description/location/site name of associated Thold devices and the hostname/description of associated Servcheck tests
 * security: Add a version-safe CSP nonce (`plugin_maint_csp_nonce()`) to every inline `<script>` tag so pages stay compatible with Cacti's Content-Security-Policy nonce enforcement, while falling back cleanly on older Cacti releases that lack the `CactiSecureHeaders` class

setup.php

@@ -177,6 +177,12 @@ function plugin_maint_check_upgrade(): void {
 		// version once every table reconciled, so a failed refresh is retried on
 		// the next request instead of being masked by a now-matching version.
 		if (maint_upgrade_tables()) {
+			// Re-register the is_device_in_maintenance hook so existing installs
+			// pick up the relocated includes/functions.php file. plugin_maint_install()
+			// registers the new path, but it never re-runs on upgrade, and core's
+			// upgrade path only touches plugin_config, never plugin_hooks.
+			api_plugin_register_hook('maint', 'is_device_in_maintenance', 'plugin_maint_check_cacti_host', 'includes/functions.php');
+
 			db_execute_prepared('UPDATE plugin_config
 				SET version = ?, name = ?, author = ?, webpage = ?
 				WHERE directory = ?',

tests/Unit/MaintCheckUpgradeTest.php

@@ -41,7 +41,8 @@
 	// db_table_exists defaults to false -> create branch; stale stored version.
 	$GLOBALS['__test_table_exists'] = [];
 	maint_test_queue('db_fetch_cell_prepared', '0.0-stale');
-	$GLOBALS['__test_db_calls'] = [];
+	$GLOBALS['__test_db_calls']         = [];
+	$GLOBALS['__test_registered_hooks'] = [];
 
 	try {
 		plugin_maint_check_upgrade();
@@ -71,8 +72,13 @@
 		return $call['fn'] === 'db_execute_prepared' && strpos($call['sql'], 'plugin_config') !== false;
 	});
 
+	$repointed = array_filter($GLOBALS['__test_registered_hooks'], function ($hook) {
+		return $hook['hook'] === 'is_device_in_maintenance' && $hook['file'] === 'includes/functions.php';
+	});
+
 	expect($created)->toContain('plugin_maint_schedules');
 	expect($created)->toContain('plugin_maint_hosts');
+	expect($repointed)->not->toBeEmpty();
 	expect($config_updates)->not->toBeEmpty();
 });