Merge pull request #314 from Canner/fix/api-parameter-type-required-bug

Fix: Fix API Parameter Type Bug Causing Undefined Error and Unintended Required Status

Author: kokokuo

packages/core/src/lib/utils/normalizedStringValue.ts

@@ -1,3 +1,4 @@
+import { isUndefined } from 'lodash';
 import { UserError } from './errors';
 
 export const canBeNormalized = (type: string) => {
@@ -7,10 +8,14 @@ export const canBeNormalized = (type: string) => {
 };
 
 export const normalizeStringValue = (
-  value: string,
+  value: string | undefined,
   dataName: string,
   dataType: string
 ) => {
+  if (isUndefined(value)) {
+    return undefined;
+  }
+
   switch (dataType.toLowerCase()) {
     case 'number': {
       if (value === '') {

packages/core/src/lib/validators/built-in-validators/dateTypeValidator.ts

@@ -39,6 +39,8 @@ export class DateTypeValidator extends InputValidator {
   }
 
   public validateData(value: string, args?: DateInputArgs) {
+    if (isUndefined(value)) return;
+
     let valid = dayjs(value).isValid();
     // if there are args passed
     if (!isUndefined(args)) {

packages/core/test/utils/normalizedStringValue.spec.ts

@@ -22,15 +22,19 @@ it.each([
   ['number', '1234', 1234],
   ['number', '-1234', -1234],
   ['number', '0', 0],
+  ['number', undefined, undefined],
   ['boolean', '', true],
   ['boolean', '1', true],
   ['boolean', 'true', true],
   ['boolean', '0', false],
   ['boolean', 'false', false],
+  ['boolean', undefined, undefined],
   ['date', '2022-08-23 14:44:23', new Date('2022-08-23 14:44:23')],
+  ['date', undefined, undefined],
   ['string', '1234', '1234'],
   ['string', 'true', 'true'],
   ['string', '', ''],
+  ['string', undefined, undefined],
 ])(
   `Normalizer should return correct value with type %s and value %p`,
   (type, value, expectedValue) => {