fix: remove special handling for comboboxes

Author: OrKoN

src/tools/input.ts

@@ -5,7 +5,7 @@
  */
 
 import {logger} from '../logger.js';
-import type {McpContext, TextSnapshotNode} from '../McpContext.js';
+import type {McpContext} from '../McpContext.js';
 import {zod} from '../third_party/index.js';
 import type {ElementHandle} from '../third_party/index.js';
 import {parseKey} from '../utils/keyboard.js';
@@ -140,61 +140,19 @@ export const hover = defineTool({
   },
 });
 
-// The AXNode for an option doesn't contain its `value`. We set text content of the option as value.
-// If the form is a combobox, we need to find the correct option by its text value.
-// To do that, loop through the children while checking which child's text matches the requested value (requested value is actually the text content).
-// When the correct option is found, use the element handle to get the real value.
-async function selectOption(
-  handle: ElementHandle,
-  aXNode: TextSnapshotNode,
-  value: string,
-) {
-  let optionFound = false;
-  for (const child of aXNode.children) {
-    if (child.role === 'option' && child.name === value && child.value) {
-      optionFound = true;
-      const childHandle = await child.elementHandle();
-      if (childHandle) {
-        try {
-          const childValueHandle = await childHandle.getProperty('value');
-          try {
-            const childValue = await childValueHandle.jsonValue();
-            if (childValue) {
-              await handle.asLocator().fill(childValue.toString());
-            }
-          } finally {
-            void childValueHandle.dispose();
-          }
-          break;
-        } finally {
-          void childHandle.dispose();
-        }
-      }
-    }
-  }
-  if (!optionFound) {
-    throw new Error(`Could not find option with text "${value}"`);
-  }
-}
-
 async function fillFormElement(
   uid: string,
   value: string,
   context: McpContext,
 ) {
   const handle = await context.getElementByUid(uid);
   try {
-    const aXNode = context.getAXNodeByUid(uid);
-    if (aXNode && aXNode.role === 'combobox') {
-      await selectOption(handle, aXNode, value);
-    } else {
-      // Increase timeout for longer input values.
-      const timeoutPerChar = 10; // ms
-      const fillTimeout =
-        context.getSelectedPage().getDefaultTimeout() +
-        value.length * timeoutPerChar;
-      await handle.asLocator().setTimeout(fillTimeout).fill(value);
-    }
+    // Increase timeout for longer input values.
+    const timeoutPerChar = 10; // ms
+    const fillTimeout =
+      context.getSelectedPage().getDefaultTimeout() +
+      value.length * timeoutPerChar;
+    await handle.asLocator().setTimeout(fillTimeout).fill(value);
   } catch (error) {
     handleActionError(error, uid);
   } finally {

tests/tools/input.test.ts

@@ -352,13 +352,40 @@ describe('input', () => {
       });
     });
 
+    it('fills out a textarea marked as combobox', async () => {
+      await withMcpContext(async (response, context) => {
+        const page = context.getSelectedPage();
+        await page.setContent(html`<textarea role="combobox" />`);
+        await context.createTextSnapshot();
+        await fill.handler(
+          {
+            params: {
+              uid: '1_1',
+              value: '1',
+            },
+          },
+          response,
+          context,
+        );
+        assert.strictEqual(
+          response.responseLines[0],
+          'Successfully filled out the element',
+        );
+        assert.ok(response.includeSnapshot);
+        assert.ok(
+          await page.evaluate(() => {
+            return document.body.querySelector('textarea')?.value === '1';
+          }),
+        );
+      });
+    });
+
     it('fills out a textarea with long text', async () => {
       await withMcpContext(async (response, context) => {
         const page = context.getSelectedPage();
         await page.setContent(html`<textarea />`);
-        await page.focus('textarea');
         await context.createTextSnapshot();
-        await page.setDefaultTimeout(1000);
+        page.setDefaultTimeout(1000);
         await fill.handler(
           {
             params: {