Skip to content

Commit 2342bb7

Browse files
fix: Remove destructiveHint per maintainer feedback
Address review feedback from @OrKoN and @sebastianbenz: - Remove all destructiveHint annotations since destructiveness is payload-dependent for browser automation tools - Keep openWorldHint: true on all tools (interact with external web) - Keep readOnlyHint for tools that only query state The destructiveness of browser automation tools cannot be reliably inferred at the tool level - a click on "Delete Account" is destructive, but a click on "Read More" is not. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
1 parent d617b73 commit 2342bb7

6 files changed

Lines changed: 0 additions & 16 deletions

File tree

src/tools/emulation.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export const emulate = defineTool({
2121
annotations: {
2222
category: ToolCategory.EMULATION,
2323
readOnlyHint: false,
24-
destructiveHint: false,
2524
openWorldHint: true,
2625
},
2726
schema: {

src/tools/input.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ export const click = defineTool({
1818
annotations: {
1919
category: ToolCategory.INPUT,
2020
readOnlyHint: false,
21-
destructiveHint: false,
2221
openWorldHint: true,
2322
},
2423
schema: {
@@ -59,7 +58,6 @@ export const hover = defineTool({
5958
annotations: {
6059
category: ToolCategory.INPUT,
6160
readOnlyHint: false,
62-
destructiveHint: false,
6361
openWorldHint: true,
6462
},
6563
schema: {
@@ -145,7 +143,6 @@ export const fill = defineTool({
145143
annotations: {
146144
category: ToolCategory.INPUT,
147145
readOnlyHint: false,
148-
destructiveHint: false,
149146
openWorldHint: true,
150147
},
151148
schema: {
@@ -175,7 +172,6 @@ export const drag = defineTool({
175172
annotations: {
176173
category: ToolCategory.INPUT,
177174
readOnlyHint: false,
178-
destructiveHint: false,
179175
openWorldHint: true,
180176
},
181177
schema: {
@@ -206,7 +202,6 @@ export const fillForm = defineTool({
206202
annotations: {
207203
category: ToolCategory.INPUT,
208204
readOnlyHint: false,
209-
destructiveHint: false,
210205
openWorldHint: true,
211206
},
212207
schema: {
@@ -240,7 +235,6 @@ export const uploadFile = defineTool({
240235
annotations: {
241236
category: ToolCategory.INPUT,
242237
readOnlyHint: false,
243-
destructiveHint: false,
244238
openWorldHint: true,
245239
},
246240
schema: {
@@ -290,7 +284,6 @@ export const pressKey = defineTool({
290284
annotations: {
291285
category: ToolCategory.INPUT,
292286
readOnlyHint: false,
293-
destructiveHint: false,
294287
openWorldHint: true,
295288
},
296289
schema: {

src/tools/pages.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ export const closePage = defineTool({
5959
annotations: {
6060
category: ToolCategory.NAVIGATION,
6161
readOnlyHint: false,
62-
destructiveHint: true,
6362
openWorldHint: true,
6463
},
6564
schema: {
@@ -89,7 +88,6 @@ export const newPage = defineTool({
8988
annotations: {
9089
category: ToolCategory.NAVIGATION,
9190
readOnlyHint: false,
92-
destructiveHint: false,
9391
openWorldHint: true,
9492
},
9593
schema: {
@@ -115,7 +113,6 @@ export const navigatePage = defineTool({
115113
annotations: {
116114
category: ToolCategory.NAVIGATION,
117115
readOnlyHint: false,
118-
destructiveHint: true,
119116
openWorldHint: true,
120117
},
121118
schema: {
@@ -213,7 +210,6 @@ export const resizePage = defineTool({
213210
annotations: {
214211
category: ToolCategory.EMULATION,
215212
readOnlyHint: false,
216-
destructiveHint: false,
217213
openWorldHint: true,
218214
},
219215
schema: {
@@ -239,7 +235,6 @@ export const handleDialog = defineTool({
239235
annotations: {
240236
category: ToolCategory.INPUT,
241237
readOnlyHint: false,
242-
destructiveHint: false,
243238
openWorldHint: true,
244239
},
245240
schema: {

src/tools/screenshot.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export const screenshot = defineTool({
1717
category: ToolCategory.DEBUGGING,
1818
// Not read-only due to filePath param.
1919
readOnlyHint: false,
20-
destructiveHint: false,
2120
openWorldHint: true,
2221
},
2322
schema: {

src/tools/script.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ so returned values have to JSON-serializable.`,
1717
annotations: {
1818
category: ToolCategory.DEBUGGING,
1919
readOnlyHint: false,
20-
destructiveHint: true,
2120
openWorldHint: true,
2221
},
2322
schema: {

src/tools/snapshot.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ in the DevTools Elements panel (if any).`,
1818
category: ToolCategory.DEBUGGING,
1919
// Not read-only due to filePath param.
2020
readOnlyHint: false,
21-
destructiveHint: false,
2221
openWorldHint: true,
2322
},
2423
schema: {

0 commit comments

Comments
 (0)