fix: move dialogHandler inside conditional block

Moved `dialogHandler` inside the `if (options?.dialog)` block to avoid unnecessarily declaring it when it is not needed. Also imported the correct `Dialog` type from Puppeteer.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Author: Lightning00Blade

src/WaitForHelper.ts

@@ -5,7 +5,7 @@
  */
 
 import {logger} from './logger.js';
-import type {Page, Protocol, CdpPage} from './third_party/index.js';
+import type {Page, Protocol, CdpPage, Dialog} from './third_party/index.js';
 import type {PredefinedNetworkConditions} from './third_party/index.js';
 
 export class WaitForHelper {
@@ -128,15 +128,16 @@ export class WaitForHelper {
     action: () => Promise<unknown>,
     options?: {timeout?: number; dialog?: 'accept' | 'dismiss'},
   ): Promise<void> {
-    const dialogHandler = (dialog: any) => {
-      if (options?.dialog === 'dismiss') {
-        void dialog.dismiss();
-      } else {
-        void dialog.accept();
-      }
-    };
+    let dialogHandler: ((dialog: Dialog) => void) | undefined;
     if (options?.dialog) {
-      this.#page.on('dialog', dialogHandler);
+      dialogHandler = (dialog: Dialog) => {
+        if (options.dialog === 'dismiss') {
+          void dialog.dismiss();
+        } else {
+          void dialog.accept();
+        }
+      };
+      (this.#page as unknown as Page).on('dialog', dialogHandler);
     }
 
     const navigationFinished = this.waitForNavigationStarted()
@@ -169,8 +170,8 @@ export class WaitForHelper {
       logger(error);
     } finally {
       this.#abortController.abort();
-      if (options?.dialog) {
-        this.#page.off('dialog', dialogHandler);
+      if (options?.dialog && dialogHandler) {
+        (this.#page as unknown as Page).off('dialog', dialogHandler);
       }
     }
   }

src/tools/script.ts

@@ -77,11 +77,12 @@ Example with arguments: \`(el) => {
         }
 
         const worker = await getWebWorker(context, serviceWorkerId);
-        await context
-          .getSelectedMcpPage()
-          .waitForEventsAfterAction(async () => {
+        await context.getSelectedMcpPage().waitForEventsAfterAction(
+          async () => {
             await performEvaluation(worker, fnString, [], response);
-          }, {dialog: 'accept'});
+          },
+          {dialog: 'accept'},
+        );
         return;
       }
 
@@ -101,9 +102,12 @@ Example with arguments: \`(el) => {
 
         const evaluatable = await getPageOrFrame(page, frames);
 
-        await mcpPage.waitForEventsAfterAction(async () => {
-          await performEvaluation(evaluatable, fnString, args, response);
-        }, {dialog: 'accept'});
+        await mcpPage.waitForEventsAfterAction(
+          async () => {
+            await performEvaluation(evaluatable, fnString, args, response);
+          },
+          {dialog: 'accept'},
+        );
       } finally {
         void Promise.allSettled(args.map(arg => arg.dispose()));
       }