Merge branch 'main' into breakpoints

Author: natorion

CONTRIBUTING.md

@@ -23,7 +23,7 @@ sign a new one.
 This project follows
 [Google's Open Source Community Guidelines](https://opensource.google/conduct/).
 
-## Contribution process
+## Development process
 
 ### Code reviews
 
@@ -53,6 +53,13 @@ completed:
   features (we want to avoid features that offer some tools but cannot be used
   successfully to debug things).
 
+### Release process
+
+Releasing `chrome-devtools-mcp` is automated by GitHub Actions. To release a new
+version, [search for a PR titled `chore(main): release chrome-devtools-mcp`](https://github.com/ChromeDevTools/chrome-devtools-mcp/pulls?q=is%3Apr+is%3Aopen+%22chore%28main%29%3A+release+chrome-devtools-mcp%22)
+and review, test, and land it. The release PR is automatically opened if there
+are any changes on the main branch that show up in the changelog.
+
 ## Installation
 
 Check that you are using node version specified in .nvmrc, then run following commands:
@@ -67,7 +74,7 @@ npm run build
 ### Testing with @modelcontextprotocol/inspector
 
 ```sh
-npx @modelcontextprotocol/inspector node build/src/index.js
+npx @modelcontextprotocol/inspector node /build/src/bin/chrome-devtools-mcp.js
 ```
 
 ### Testing with an MCP client
@@ -79,7 +86,7 @@ Add the MCP server to your client's config.
   "mcpServers": {
     "chrome-devtools": {
       "command": "node",
-      "args": ["/path-to/build/src/index.js"]
+      "args": ["/path-to/build/src/bin/chrome-devtools-mcp.js"]
     }
   }
 }
@@ -95,7 +102,7 @@ Usually VS Code automatically detects and forwards `6274` but fails to detect `6
 To write debug logs to `log.txt` in the working directory, run with the following commands:
 
 ```sh
-npx @modelcontextprotocol/inspector node build/src/index.js --log-file=/your/desired/path/log.txt
+npx @modelcontextprotocol/inspector node /build/src/bin/chrome-devtools-mcp.js --log-file=/your/desired/path/log.txt
 ```
 
 You can use the `DEBUG` environment variable as usual to control categories that are logged.

package-lock.json

@@ -114,10 +114,12 @@ y.command('status', 'Checks if chrome-devtools-mcp is running', async () => {
         socketPath: string;
         startDate: string;
         version: string;
+        args: string[];
       };
       console.log(
         `pid=${data.pid} socket=${data.socketPath} start-date=${data.startDate} version=${data.version}`,
       );
+      console.log(`args=${JSON.stringify(data.args)}`);
     } else {
       console.error('Error:', response.error);
       process.exit(1);

src/bin/chrome-devtools.ts

@@ -85,6 +85,7 @@ export async function startDaemon(mcpArgs: string[] = []) {
     stdio: 'ignore',
     env: process.env,
     cwd: process.cwd(),
+    windowsHide: true,
   });
   child.unref();
 

src/daemon/client.ts

@@ -44,6 +44,7 @@ logger(`Writing ${process.pid.toString()} to ${pidFilePath}`);
 const socketPath = getSocketPath();
 
 const startDate = new Date();
+const mcpServerArgs = process.argv.slice(2);
 
 let mcpClient: Client | null = null;
 let mcpTransport: StdioClientTransport | null = null;
@@ -52,11 +53,14 @@ let server: Server | null = null;
 async function setupMCPClient() {
   console.log('Setting up MCP client connection...');
 
-  const args = process.argv.slice(2);
   // Create stdio transport for chrome-devtools-mcp
+  // Workaround for https://github.com/modelcontextprotocol/typescript-sdk/blob/v1.x/src/client/stdio.ts#L128
+  // which causes the console window to show on Windows.
+  // @ts-expect-error no types for type.
+  process.type = 'mcp-client';
   mcpTransport = new StdioClientTransport({
     command: process.execPath,
-    args: [INDEX_SCRIPT_PATH, ...args],
+    args: [INDEX_SCRIPT_PATH, ...mcpServerArgs],
     env: process.env as Record<string, string>,
   });
   mcpClient = new Client(
@@ -118,6 +122,7 @@ async function handleRequest(msg: DaemonMessage) {
           socketPath,
           startDate: startDate.toISOString(),
           version: VERSION,
+          args: mcpServerArgs,
         }),
       };
     }

src/daemon/daemon.ts

@@ -162,13 +162,18 @@ describe('pages', () => {
 
           assert.ok(extensionId);
 
-          const _sidePanelPage = await context.newPage();
-          await _sidePanelPage.pptrPage.goto(
+          const sidePanelPage = await context.newPage();
+          await sidePanelPage.pptrPage.goto(
             `chrome-extension://${extensionId}/sidepanel.html`,
           );
 
           await context.waitForTextOnPage(['Side Panel']);
 
+          // Wait for service worker used in the snapshot.
+          await context.browser.waitForTarget(
+            target => target.type() === 'service_worker',
+          );
+
           const listPageDef = listPages({
             categoryExtensions: true,
           } as ParsedArguments);