refactor: address pr comments

Author: nroscino

tests/tools/extensions.test.ts

@@ -19,7 +19,7 @@ import {
   triggerExtensionAction,
 } from '../../src/tools/extensions.js';
 import {listPages} from '../../src/tools/pages.js';
-import {extractId, withMcpContext} from '../utils.js';
+import {extractExtensionId, withMcpContext} from '../utils.js';
 
 const EXTENSION_WITH_SW_PATH = path.join(
   import.meta.dirname,
@@ -44,7 +44,7 @@ describe('extension', () => {
         context,
       );
 
-      const extensionId = extractId(response);
+      const extensionId = extractExtensionId(response);
       const page = context.getSelectedPptrPage();
       await page.goto('chrome://extensions');
 
@@ -99,7 +99,7 @@ describe('extension', () => {
         context,
       );
 
-      const extensionId = extractId(response);
+      const extensionId = extractExtensionId(response);
       const installSpy = sinon.spy(context, 'installExtension');
       response.resetResponseLineForTesting();
 
@@ -132,7 +132,6 @@ describe('extension', () => {
           EXTENSION_WITH_SW_PATH,
         );
 
-        response.resetResponseLineForTesting();
         const listPageDef = listPages({
           categoryExtensions: true,
         } as ParsedArguments);

tests/tools/script.test.ts

@@ -12,7 +12,7 @@ import type {ParsedArguments} from '../../src/cli.js';
 import {installExtension} from '../../src/tools/extensions.js';
 import {evaluateScript} from '../../src/tools/script.js';
 import {serverHooks} from '../server.js';
-import {extractId, html, withMcpContext} from '../utils.js';
+import {extractExtensionId, html, withMcpContext} from '../utils.js';
 
 const EXTENSION_PATH = path.join(
   import.meta.dirname,
@@ -207,7 +207,7 @@ describe('script', () => {
             context,
           );
 
-          const extensionId = extractId(response);
+          const extensionId = extractExtensionId(response);
           const swTarget = await context.browser.waitForTarget(
             t => t.type() === 'service_worker' && t.url().includes(extensionId),
           );

tests/utils.ts

@@ -44,7 +44,7 @@ export function getImageContent(content: CallToolResult['content'][number]): {
   throw new Error(`Expected image content but got ${content.type}`);
 }
 
-export function extractId(response: McpResponse) {
+export function extractExtensionId(response: McpResponse) {
   const responseLine = response.responseLines[0];
   assert.ok(responseLine, 'Response should not be empty');
   const match = responseLine.match(/Extension installed\. Id: (.+)/);
@@ -101,7 +101,6 @@ export async function withMcpContext(
     debug?: boolean;
     autoOpenDevTools?: boolean;
     performanceCrux?: boolean;
-    channel?: string;
     executablePath?: string;
   } = {},
   args: ParsedArguments = {} as ParsedArguments,