chore: update extension action trigger test to use snapshot testing

Author: nroscino

tests/tools/extensions.test.js.snapshot

@@ -0,0 +1,13 @@
+exports[`extension > triggers an extension action 1`] = `
+# list_pages response
+## Pages
+1: about:blank [selected]
+## Extension Service Workers
+`;
+
+exports[`extension > triggers an extension action 2`] = `
+# list_pages response
+## Pages
+1: about:blank [selected]
+sw-1: chrome-extension://<extension-id>/sw.js
+`;

tests/tools/extensions.test.ts

@@ -11,7 +11,6 @@ import {afterEach, describe, it} from 'node:test';
 import sinon from 'sinon';
 
 import type {ParsedArguments} from '../../src/cli.js';
-import type {McpResponse} from '../../src/McpResponse.js';
 import {
   installExtension,
   uninstallExtension,
@@ -20,7 +19,7 @@ import {
   triggerExtensionAction,
 } from '../../src/tools/extensions.js';
 import {listPages} from '../../src/tools/pages.js';
-import {withMcpContext} from '../utils.js';
+import {extractId, withMcpContext} from '../utils.js';
 
 const EXTENSION_WITH_SW_PATH = path.join(
   import.meta.dirname,
@@ -31,15 +30,6 @@ const EXTENSION_PATH = path.join(
   '../../../tests/tools/fixtures/extension',
 );
 
-export function extractId(response: McpResponse) {
-  const responseLine = response.responseLines[0];
-  assert.ok(responseLine, 'Response should not be empty');
-  const match = responseLine.match(/Extension installed\. Id: (.+)/);
-  const extensionId = match ? match[1] : null;
-  assert.ok(extensionId, 'Response should contain a valid key');
-  return extensionId;
-}
-
 describe('extension', () => {
   afterEach(() => {
     sinon.restore();
@@ -135,17 +125,13 @@ describe('extension', () => {
       assert.ok(reinstalled, 'Extension should be present after reload');
     });
   });
-  it('triggers an extension action', async () => {
+  it('triggers an extension action', async t => {
     await withMcpContext(
       async (response, context) => {
-        await installExtension.handler(
-          {params: {path: EXTENSION_WITH_SW_PATH}},
-          response,
-          context,
+        const extensionId = await context.installExtension(
+          EXTENSION_WITH_SW_PATH,
         );
 
-        const extensionId = extractId(response);
-
         response.resetResponseLineForTesting();
         const listPageDef = listPages({
           categoryExtensions: true,
@@ -160,9 +146,8 @@ describe('extension', () => {
           type: 'text';
           text: string;
         };
-        assert.ok(
-          !textContent.text.includes(extensionId),
-          'Response should not contain extension service worker id',
+        t.assert.snapshot?.(
+          textContent.text.replaceAll(extensionId, '<extension-id>'),
         );
 
         await triggerExtensionAction.handler(
@@ -187,9 +172,11 @@ describe('extension', () => {
           type: 'text';
           text: string;
         };
-        assert.ok(
-          textContent.text.includes(swUrl),
-          'Response should contain extension service worker url',
+        t.assert.snapshot?.(
+          textContent.text
+            .replaceAll(extensionId, '<extension-id>')
+            .replaceAll(swUrl, '<sw-url>')
+            .replaceAll(/localhost:\d+/g, 'localhost:<port>'),
         );
       },
       {

tests/tools/script.test.ts

@@ -12,9 +12,7 @@ import type {ParsedArguments} from '../../src/cli.js';
 import {installExtension} from '../../src/tools/extensions.js';
 import {evaluateScript} from '../../src/tools/script.js';
 import {serverHooks} from '../server.js';
-import {html, withMcpContext} from '../utils.js';
-
-import {extractId} from './extensions.test.js';
+import {extractId, html, withMcpContext} from '../utils.js';
 
 const EXTENSION_PATH = path.join(
   import.meta.dirname,

tests/utils.ts

@@ -4,12 +4,13 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import assert from 'node:assert';
+
 import type {CallToolResult} from '@modelcontextprotocol/sdk/types.js';
 import logger from 'debug';
 import type {Browser} from 'puppeteer';
 import puppeteer, {Locator} from 'puppeteer';
 import type {
-  ChromeReleaseChannel,
   Frame,
   HTTPRequest,
   HTTPResponse,
@@ -43,6 +44,15 @@ export function getImageContent(content: CallToolResult['content'][number]): {
   throw new Error(`Expected image content but got ${content.type}`);
 }
 
+export function extractId(response: McpResponse) {
+  const responseLine = response.responseLines[0];
+  assert.ok(responseLine, 'Response should not be empty');
+  const match = responseLine.match(/Extension installed\. Id: (.+)/);
+  const extensionId = match ? match[1] : null;
+  assert.ok(extensionId, 'Response should contain a valid key');
+  return extensionId;
+}
+
 const browsers = new Map<string, Browser>();
 let context: McpContext | undefined;
 
@@ -51,16 +61,12 @@ export async function withBrowser(
   options: {
     debug?: boolean;
     autoOpenDevTools?: boolean;
-    channel?: string;
     executablePath?: string;
   } = {},
 ) {
   const launchOptions: LaunchOptions = {
     executablePath:
       options.executablePath ?? process.env.PUPPETEER_EXECUTABLE_PATH,
-    channel: (options.executablePath
-      ? undefined
-      : options.channel) as ChromeReleaseChannel,
     headless: !options.debug,
     defaultViewport: null,
     devtools: options.autoOpenDevTools ?? false,