[Telemetry] Fix death detection reliability by detaching watchdog process

Author: ergunsh

src/telemetry/watchdog-client.ts

@@ -41,7 +41,7 @@ export class WatchdogClient {
     const spawner = options?.spawn ?? spawn;
     this.#childProcess = spawner(process.execPath, args, {
       stdio: ['pipe', 'ignore', 'ignore'],
-      detached: false,
+      detached: true,
     });
 
     this.#childProcess.unref();

src/telemetry/watchdog/main.ts

@@ -67,7 +67,6 @@ async function main() {
 
   process.stdin.on('end', () => onParentDeath('stdin end'));
   process.stdin.on('close', () => onParentDeath('stdin close'));
-
   process.on('disconnect', () => onParentDeath('ipc disconnect'));
 
   const rl = readline.createInterface({

tests/telemetry/watchdog-client.test.ts

@@ -59,6 +59,7 @@ describe('WatchdogClient', () => {
     assert.strictEqual(cmdArgs.includes('--parent-pid=100'), true);
     assert.strictEqual(cmdArgs.includes('--app-version=1.2.3'), true);
     assert.strictEqual(cmdArgs.includes('--os-type=2'), true);
+    assert.strictEqual(spawnStub.firstCall.args[2].detached, true);
   });
 
   it('passes log-file argument if provided', () => {