feat(collector): add maxItemsSavedPerNavigation to prevent unbounded memory growth\n\n- Introduce protected maxItemsSavedPerNavigation in PageCollector\n- NetworkCollector sets to 5000, ConsoleCollector to 1000\n- Add pruning logic to current navigation array\n- Add test for pruning behavior\n\nFixes #1214. This addresses memory growth in autoConnect mode where collectors could accumulate unlimited items in a single navigation if the page never navigates but makes many requests/console events.

Author: gilangjavier

src/PageCollector.ts

@@ -64,6 +64,14 @@ export class PageCollector<T> {
   #listeners = new WeakMap<Page, ListenerMap>();
   protected maxNavigationSaved = 3;
 
+  /**
+   * Max number of collected items to keep for the *current* navigation.
+   *
+   * This is a safety valve to prevent unbounded memory growth in long-running
+   * sessions (e.g. autoConnect mode) on highly active pages.
+   */
+  protected maxItemsSavedPerNavigation = Number.POSITIVE_INFINITY;
+
   /**
    * This maps a Page to a list of navigations with a sub-list
    * of all collected resources.
@@ -134,7 +142,9 @@ export class PageCollector<T> {
       withId[stableIdSymbol] = idGenerator();
 
       const navigations = this.storage.get(page) ?? [[]];
-      navigations[0].push(withId);
+      const current = navigations[0];
+      current.push(withId);
+      this.#pruneCurrentNavigation(current);
     });
 
     listeners['framenavigated'] = (frame: Frame) => {
@@ -152,6 +162,20 @@ export class PageCollector<T> {
     this.#listeners.set(page, listeners);
   }
 
+  #pruneCurrentNavigation(navigation: Array<WithSymbolId<T>>) {
+    const max = this.maxItemsSavedPerNavigation;
+    if (!Number.isFinite(max)) {
+      return;
+    }
+    if (max <= 0) {
+      navigation.length = 0;
+      return;
+    }
+    if (navigation.length > max) {
+      navigation.splice(0, navigation.length - max);
+    }
+  }
+
   protected splitAfterNavigation(page: Page) {
     const navigations = this.storage.get(page);
     if (!navigations) {
@@ -234,6 +258,8 @@ export class ConsoleCollector extends PageCollector<
 > {
   #subscribedPages = new WeakMap<Page, PageEventSubscriber>();
 
+  protected override maxItemsSavedPerNavigation = 1000;
+
   override addPage(page: Page): void {
     super.addPage(page);
     if (!this.#subscribedPages.has(page)) {
@@ -372,6 +398,8 @@ class PageEventSubscriber {
 }
 
 export class NetworkCollector extends PageCollector<HTTPRequest> {
+  protected override maxItemsSavedPerNavigation = 5000;
+
   constructor(
     browser: Browser,
     listeners: (

tests/PageCollector.test.ts

@@ -185,6 +185,37 @@ describe('PageCollector', () => {
     assert.equal(collector.getIdForResource(request1), 1);
     assert.equal(collector.getIdForResource(request2), 2);
   });
+
+  it('should prune current navigation to maxItemsSavedPerNavigation', async () => {
+    const browser = getMockBrowser();
+    const page = (await browser.pages())[0];
+
+    class LimitedCollector extends PageCollector<HTTPRequest> {
+      protected override maxItemsSavedPerNavigation = 2;
+    }
+
+    const request1 = getMockRequest({url: 'http://example.com/1'});
+    const request2 = getMockRequest({url: 'http://example.com/2'});
+    const request3 = getMockRequest({url: 'http://example.com/3'});
+
+    const collector = new LimitedCollector(browser, collect => {
+      return {
+        request: req => {
+          collect(req);
+        },
+      } as ListenerMap;
+    });
+    await collector.init([page]);
+
+    page.emit('request', request1);
+    page.emit('request', request2);
+    page.emit('request', request3);
+
+    const data = collector.getData(page);
+    assert.equal(data.length, 2);
+    assert.equal(data[0], request2);
+    assert.equal(data[1], request3);
+  });
 });
 
 describe('NetworkCollector', () => {