works

Change-Id: I2b5dcda9b32db8ec0ca1270e267edfeb562ff7b5

Author: paulirish

package-lock.json

@@ -194,50 +194,37 @@ async function stopTracingAndAppendOutput(
 }
 
 async function populateCruxData(result: TraceResult): Promise<void> {
-  try {
-    logger('populateCruxData called');
-    const cruxManager = DevTools.CrUXManager.CrUXManager.instance();
-    cruxManager.setEndpointForTesting(
-      'https://chromeuxreport.googleapis.com/v1/records:queryRecord?key=AIzaSyBn5gimNjhiEyA_euicSKko6IlD3HdgUfk',
-    );
-    const settings = DevTools.Common.Settings.Settings.instance();
-    const cruxSetting = settings.createSetting('field-data', {enabled: true});
-
-    if (!cruxSetting.get().enabled) {
-      logger('CrUX is disabled in settings');
-      return;
-    }
-
-    const urls = new Set<string>();
-    if (result.insights) {
-      for (const insightSet of result.insights.values()) {
-        urls.add(insightSet.url.href);
-      }
-    } else {
-      const mainUrl = result.parsedTrace.data.Meta.mainFrameURL;
-      if (mainUrl) {
-        urls.add(mainUrl);
-      }
-    }
-
-    if (urls.size === 0) {
-      logger('No URLs found for CrUX data');
-      return;
-    }
-
-    logger(
-      `Fetching CrUX data for ${urls.size} URLs: ${Array.from(urls).join(', ')}`,
-    );
-    const cruxData = await Promise.all(
-      Array.from(urls).map(async url => {
-        const data = await cruxManager.getFieldDataForPage(url);
-        logger(`CrUX data for ${url}: ${data ? 'found' : 'not found'}`);
-        return data;
-      }),
-    );
-
-    result.parsedTrace.metadata.cruxFieldData = cruxData;
-  } catch (err) {
-    logger('Error populating CrUX data:', err);
+  logger('populateCruxData called');
+  const cruxManager = DevTools.CrUXManager.CrUXManager.instance();
+  // go/jtfbx
+  cruxManager.setEndpointForTesting(
+    'https://chromeuxreport.googleapis.com/v1/records:queryRecord?key=AIzaSyBn5gimNjhiEyA_euicSKko6IlD3HdgUfk',
+  );
+  const settings = DevTools.Common.Settings.Settings.instance();
+  const cruxSetting = settings.createSetting('field-data', {enabled: true});
+  cruxSetting.set({enabled: true});
+
+  // Gather URLs to fetch CrUX data for
+  const urls = [...(result.parsedTrace.insights?.values() ?? [])].map(c =>
+    c.url.toString(),
+  );
+  urls.push(result.parsedTrace.data.Meta.mainFrameURL);
+  const urlSet = new Set(urls);
+
+  if (urlSet.size === 0) {
+    logger('No URLs found for CrUX data');
+    return;
   }
+  logger(
+    `Fetching CrUX data for ${urlSet.size} URLs: ${Array.from(urlSet).join(', ')}`,
+  );
+  const cruxData = await Promise.all(
+    Array.from(urlSet).map(async url => {
+      const data = await cruxManager.getFieldDataForPage(url);
+      logger(`CrUX data for ${url}: ${data ? 'found' : 'not found'}`);
+      return data;
+    }),
+  );
+
+  result.parsedTrace.metadata.cruxFieldData = cruxData;
 }

src/tools/performance.ts

@@ -71,7 +71,7 @@ exports[`McpResponse > adds throttling setting when it is not null 1`] = `
 # test response
 ## Network emulation
 Emulating: Slow 3G
-Default navigation timeout set to 100000 ms
+Default navigation timeout set to 600000 ms
 `;
 
 exports[`McpResponse > allows response text lines to be added 1`] = `

tests/McpResponse.test.js.snapshot

@@ -73,7 +73,19 @@ Metrics (lab / observed):
     - Load duration: 15 ms, bounds: {min: 122411037986, max: 122411052690}
     - Render delay: 73 ms, bounds: {min: 122411052690, max: 122411126100}
   - CLS: 0.00
-Metrics (field / real users): n/a – no data for this page in CrUX
+Metrics (field / real users):
+  - LCP: 2595 ms (scope: url)
+  - LCP breakdown:
+    - TTFB: 1273 ms (scope: url)
+    - Load delay: 86 ms (scope: url)
+    - Load duration: 451 ms (scope: url)
+    - Render delay: 786 ms (scope: url)
+  - INP: 140 ms (scope: url)
+  - CLS: 0.06 (scope: url)
+  - The above data is from CrUX–Chrome User Experience Report. It's how the page performs for real users.
+  - The values shown above are the p75 measure of all real Chrome users
+  - The scope indicates if the data came from the entire origin, or a specific url
+  - Lab metrics describe how this specific page load performed, while field metrics are an aggregation of results from real-world users. Best practice is to prioritize metrics that are bad in field data. Lab metrics may be better or worse than fields metrics depending on the developer's machine, network, or the actions performed while tracing.
 Available insights:
   - insight name: LCPBreakdown
     description: Each [subpart has specific improvement strategies](https://developer.chrome.com/docs/performance/insights/lcp-breakdown). Ideally, most of the LCP time should be spent on loading the resources, not within delays.

tests/tools/performance.test.js.snapshot

@@ -75,7 +75,7 @@ describe('performance', () => {
       });
     });
 
-    it.only('can autostop and store a recording', async () => {
+    it('can autostop and store a recording', async () => {
       const rawData = loadTraceAsBuffer('basic-trace.json.gz');
 
       await withMcpContext(async (response, context) => {