feat(cli, config, logger, main, file-read, symbol-resolver): remove logFile references and enhance error handling

Author: AndyLiner13

src/cli.ts

@@ -65,11 +65,6 @@ export const cliOptions = {
     default: false,
     hidden: true,
   },
-  logFile: {
-    type: 'string',
-    describe: '[LEGACY] Set logFile in .vscode/devtools.json instead.',
-    hidden: true,
-  },
   experimentalVision: {
     type: 'boolean',
     describe: 'Whether to enable vision tools.',

src/config.ts

@@ -77,7 +77,7 @@ const DEFAULT_CONFIG_TEMPLATE = `// VS Code DevTools MCP configuration (JSONC)
   "devDiagnostic": false,
 
   // Write logs to a file (absolute or relative path).
-  // "logFile": ".devtools/devtools-mcp.log",
+  // Logs are written to stderr and appear in VS Code's MCP output channel.
 
   // Run VS Code headless (Linux only).
   "headless": false,
@@ -134,9 +134,6 @@ export interface DevToolsConfig {
   /** Enable diagnostic tools (debug_evaluate) */
   devDiagnostic?: boolean;
 
-  /** Path to log file (relative to workspace or absolute) */
-  logFile?: string;
-
   /** Run VS Code headless (Linux only) */
   headless?: boolean;
 
@@ -162,7 +159,6 @@ export interface ResolvedConfig {
   /** True when the extension dev path was explicitly supplied via CLI args. */
   explicitExtensionDevelopmentPath: boolean;
   devDiagnostic: boolean;
-  logFile?: string;
   headless: boolean;
   experimentalVision: boolean;
   experimentalStructuredContent: boolean;
@@ -214,9 +210,6 @@ function coerceDevToolsConfig(value: unknown): DevToolsConfig {
   const devDiagnostic = readOptionalBoolean(value, 'devDiagnostic');
   if (typeof devDiagnostic === 'boolean') {config.devDiagnostic = devDiagnostic;}
 
-  const logFile = readOptionalString(value, 'logFile');
-  if (logFile) {config.logFile = logFile;}
-
   const headless = readOptionalBoolean(value, 'headless');
   if (typeof headless === 'boolean') {config.headless = headless;}
 
@@ -393,7 +386,6 @@ export function loadConfig(cliArgs: {
   extensionBridgePath?: string;
   targetFolder?: string;
   devDiagnostic?: boolean;
-  logFile?: string;
   headless?: boolean;
   experimentalVision?: boolean;
   experimentalStructuredContent?: boolean;
@@ -459,18 +451,12 @@ export function loadConfig(cliArgs: {
     extensionBridgePath = getDefaultExtensionPath();
   }
 
-  // Resolve log file path
-  const logFile =
-    cliArgs.logFile ??
-    resolvePath(absoluteWorkspace, fileConfig.logFile);
-
   return {
     hostWorkspace: getHostWorkspace(),
     workspaceFolder: absoluteWorkspace,
     extensionBridgePath,
     explicitExtensionDevelopmentPath,
     devDiagnostic: cliArgs.devDiagnostic ?? fileConfig.devDiagnostic ?? false,
-    logFile,
     headless: cliArgs.headless ?? fileConfig.headless ?? false,
     experimentalVision:
       cliArgs.experimentalVision ?? fileConfig.experimentalVision ?? false,

src/logger.ts

@@ -4,8 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import fs from 'node:fs';
-
 import {debug} from './third_party/index.js';
 
 const mcpDebugNamespace = 'mcp:log';
@@ -28,8 +26,7 @@ function formatLogChunks(chunks: unknown[]): string {
   return raw.replace(DEBUG_PREFIX_RE, '').replace(DEBUG_SUFFIX_RE, '');
 }
 
-// Always enable the mcp:log namespace so output is visible.
-// By default, write to stderr in a clean timestamped format.
+// All logs go to stderr only.
 // stderr output appears in the host VS Code's MCP output channel
 // as "[server stderr]" entries, giving full visibility via read_output_channels.
 debug.enable(namespacesToEnable.join(','));
@@ -38,38 +35,4 @@ debug.log = function (...chunks: unknown[]) {
   process.stderr.write(`[${ts}] ${formatLogChunks(chunks)}\n`);
 };
 
-export function saveLogsToFile(fileName: string): fs.WriteStream {
-  // Re-enable (idempotent) and tee output to BOTH stderr and the log file.
-  // stderr output appears in the host VS Code's MCP output channel;
-  // the file provides a persistent on-disk record for post-mortem analysis.
-  debug.enable(namespacesToEnable.join(','));
-
-  const logFile = fs.createWriteStream(fileName, {flags: 'a+'});
-  debug.log = function (...chunks: unknown[]) {
-    const ts = new Date().toISOString();
-    const line = `[${ts}] ${formatLogChunks(chunks)}\n`;
-    process.stderr.write(line);
-    logFile.write(line);
-  };
-  logFile.on('error', function (error) {
-    console.error(`Error when opening/writing to log file: ${error.message}`);
-    logFile.end();
-    process.exit(1);
-  });
-  return logFile;
-}
-
-export function flushLogs(
-  logFile: fs.WriteStream,
-  timeoutMs = 2000,
-): Promise<void> {
-  return new Promise((resolve, reject) => {
-    const timeout = setTimeout(reject, timeoutMs);
-    logFile.end(() => {
-      clearTimeout(timeout);
-      resolve();
-    });
-  });
-}
-
 export const logger = debug(mcpDebugNamespace);

src/main.ts

@@ -15,7 +15,7 @@ import {loadConfig, type ResolvedConfig} from './config.js';
 import {hasBuildChangedSinceWindowStart, isBuildStale, writeExtSourceFingerprint} from './extension-watcher.js';
 import {restartMcpServer, showHostNotification} from './host-pipe.js';
 import {loadIssueDescriptions} from './issue-descriptions.js';
-import {logger, saveLogsToFile} from './logger.js';
+import {logger} from './logger.js';
 import {McpResponse} from './McpResponse.js';
 import {
   consumeHotReloadMarker,
@@ -228,10 +228,9 @@ function formatProcessLedger(ledger: ProcessLedgerSummary): string {
     }
   }
 
-  // If nothing to report
+  // If nothing to report, return empty string (no notification)
   if (ledger.orphaned.length === 0 && sessions.length === 0 && ledger.active.length === 0 && completed.length === 0) {
-    parts.push('\n---');
-    parts.push('\n📋 **No Copilot-managed processes running.**');
+    return '';
   }
 
   return parts.join('');
@@ -273,10 +272,6 @@ export const config: ResolvedConfig = loadConfig(cliArgs);
 // Legacy export for backwards compatibility
 export const args = cliArgs;
 
-if (config.logFile) {
-  saveLogsToFile(config.logFile);
-}
-
 // ── MCP Server Hot-Reload Marker (detect post-restart) ───
 // Check this BEFORE initializing lifecycle service so we can pass the flag
 const _hotReloadBuildTime = consumeHotReloadMarker(mcpServerDir);
@@ -322,7 +317,7 @@ process.on('unhandledRejection', (reason, promise) => {
 
 logger(`Starting VS Code DevTools MCP Server v${VERSION}`);
 logger(`Config: hostWorkspace=${config.hostWorkspace}, targetFolder=${config.workspaceFolder}`);
-logger(`Config: extensionBridgePath=${config.extensionBridgePath}, headless=${config.headless}, logFile=${config.logFile ?? '(none)'}`);
+logger(`Config: extensionBridgePath=${config.extensionBridgePath}, headless=${config.headless}`);
 const server = new McpServer(
   {
     name: 'vscode_devtools',
@@ -598,7 +593,9 @@ function registerTool(tool: ToolDefinition): void {
           if (!response.skipLedger) {
             const ledger = await getProcessLedger();
             const ledgerText = formatProcessLedger(ledger);
-            content.push({type: 'text', text: ledgerText});
+            if (ledgerText) {
+              content.push({type: 'text', text: ledgerText});
+            }
           }
 
           return {content};

src/tools/file/file-read.ts

@@ -4,6 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import fs from 'node:fs';
 import path from 'node:path';
 
 import {
@@ -460,6 +461,20 @@ export const read = defineTool({
   handler: async (request, response) => {
     const {params} = request;
     const filePath = resolveFilePath(params.file);
+
+    if (!fs.existsSync(filePath)) {
+      response.appendResponseLine(
+        `**Error:** File not found: \`${filePath}\``,
+      );
+      if (!path.isAbsolute(params.file)) {
+        response.appendResponseLine(
+          `The relative path \`${params.file}\` was resolved against the workspace root. ` +
+          'Use an absolute path or a path relative to the workspace root.',
+        );
+      }
+      return;
+    }
+
     const skeleton = params.skeleton ?? false;
     const recursive = params.recursive ?? false;
 

src/tools/file/symbol-resolver.ts

@@ -8,9 +8,15 @@
  * Minimum shape required for symbol tree navigation.
  * Both FileSymbol and UnifiedFileSymbol satisfy this.
  */
+export interface SymbolLikeRange {
+  startLine: number;
+  endLine: number;
+}
+
 export interface SymbolLike {
   name: string;
   kind: string;
+  range: SymbolLikeRange;
   children: SymbolLike[];
 }