chore(deps-dev): bump chrome-devtools-frontend from 1.0.1613625 to 1.0.1616061 (#1952)

Closes #1908

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piotr Paulski <piotrpaulski@chromium.org>

Author: 3 people

src/McpContext.ts

@@ -165,7 +165,10 @@ export class McpContext implements Context {
     this.#roots = roots;
   }
 
-  validatePath(filePath: string): void {
+  validatePath(filePath?: string): void {
+    if (filePath === undefined) {
+      return;
+    }
     const roots = this.roots();
     if (roots === undefined) {
       return;
@@ -676,7 +679,11 @@ export class McpContext implements Context {
   ): Promise<{filepath: string}> {
     const filepath = await getTempFilePath(filename);
     this.validatePath(filepath);
-    await fs.writeFile(filepath, data);
+    try {
+      await fs.writeFile(filepath, data);
+    } catch (err) {
+      throw new Error('Could not save a file', {cause: err});
+    }
     return {filepath};
   }
 

src/tools/ToolDefinition.ts

@@ -170,7 +170,7 @@ export type SupportedExtensions =
  * Only add methods used by tools/*.
  */
 export type Context = Readonly<{
-  validatePath(filePath: string): void;
+  validatePath(filePath?: string): void;
   isRunningPerformanceTrace(): boolean;
   setIsRunningPerformanceTrace(x: boolean): void;
   isCruxEnabled(): boolean;

src/tools/lighthouse.ts

@@ -53,9 +53,7 @@ export const lighthouseAudit = definePageTool({
       outputDirPath,
     } = request.params;
 
-    if (outputDirPath) {
-      context.validatePath(outputDirPath);
-    }
+    context.validatePath(outputDirPath);
 
     const flags: Flags = {
       onlyCategories: categories,

src/tools/network.ts

@@ -114,12 +114,8 @@ export const getNetworkRequest = definePageTool({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.requestFilePath) {
-      context.validatePath(request.params.requestFilePath);
-    }
-    if (request.params.responseFilePath) {
-      context.validatePath(request.params.responseFilePath);
-    }
+    context.validatePath(request.params.requestFilePath);
+    context.validatePath(request.params.responseFilePath);
     if (request.params.reqid) {
       response.attachNetworkRequest(request.params.reqid, {
         requestFilePath: request.params.requestFilePath,

src/tools/performance.ts

@@ -49,9 +49,7 @@ export const startTrace = definePageTool({
     filePath: filePathSchema,
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (context.isRunningPerformanceTrace()) {
       response.appendResponseLine(
         'Error: a performance trace is already running. Use performance_stop_trace to stop it. Only one trace can be running at any given time.',
@@ -129,9 +127,7 @@ export const stopTrace = definePageTool({
     filePath: filePathSchema,
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (!context.isRunningPerformanceTrace()) {
       return;
     }

src/tools/screencast.ts

@@ -40,9 +40,7 @@ export const startScreencast = definePageTool(args => ({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (context.getScreenRecorder() !== null) {
       response.appendResponseLine(
         'Error: a screencast recording is already in progress. Use screencast_stop to stop it before starting a new one.',

src/tools/screenshot.ts

@@ -51,9 +51,7 @@ export const screenshot = definePageTool({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (request.params.uid && request.params.fullPage) {
       throw new Error('Providing both "uid" and "fullPage" is not allowed.');
     }

src/tools/snapshot.ts

@@ -34,9 +34,7 @@ in the DevTools Elements panel (if any).`,
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     response.includeSnapshot({
       verbose: request.params.verbose ?? false,
       filePath: request.params.filePath,