chore: re-use puppeteer issues

Author: OrKoN

src/McpContext.ts

@@ -117,7 +117,7 @@ export class McpContext implements Context {
         uncaughtError: event => {
           collect(event);
         },
-        issue: event => {
+        devtoolsAggregatedIssue: event => {
           collect(event);
         },
       } as ListenerMap;

src/PageCollector.ts

@@ -11,6 +11,7 @@ import type {
   CDPSession,
   ConsoleMessage,
   Protocol,
+  Issue,
 } from './third_party/index.js';
 import {DevTools} from './third_party/index.js';
 import {
@@ -33,7 +34,7 @@ export class UncaughtError {
 }
 
 interface PageEvents extends PuppeteerPageEvents {
-  issue: DevTools.AggregatedIssue;
+  devtoolsAggregatedIssue: DevTools.AggregatedIssue;
   uncaughtError: UncaughtError;
 }
 
@@ -285,7 +286,7 @@ class PageEventSubscriber {
   async subscribe() {
     this.#resetIssueAggregator();
     this.#page.on('framenavigated', this.#onFrameNavigated);
-    this.#session.on('Audits.issueAdded', this.#onIssueAdded);
+    this.#page.on('issue', this.#onIssueAdded);
     this.#session.on('Runtime.exceptionThrown', this.#onExceptionThrown);
     try {
       await this.#session.send('Audits.enable');
@@ -298,7 +299,7 @@ class PageEventSubscriber {
     this.#seenKeys.clear();
     this.#seenIssues.clear();
     this.#page.off('framenavigated', this.#onFrameNavigated);
-    this.#session.off('Audits.issueAdded', this.#onIssueAdded);
+    this.#page.off('issue', this.#onIssueAdded);
     this.#session.off('Runtime.exceptionThrown', this.#onExceptionThrown);
     if (this.#issueAggregator) {
       this.#issueAggregator.removeEventListener(
@@ -318,7 +319,7 @@ class PageEventSubscriber {
       return;
     }
     this.#seenIssues.add(event.data);
-    this.#page.emit('issue', event.data);
+    this.#page.emit('devtoolsAggregatedIssue', event.data);
   };
 
   #onExceptionThrown = (event: Protocol.Runtime.ExceptionThrownEvent) => {
@@ -339,9 +340,8 @@ class PageEventSubscriber {
     this.#resetIssueAggregator();
   };
 
-  #onIssueAdded = (data: Protocol.Audits.IssueAddedEvent) => {
+  #onIssueAdded = (inspectorIssue: Issue) => {
     try {
-      const inspectorIssue = data.issue;
       const issue = DevTools.createIssuesFromProtocolIssue(
         null,
         // @ts-expect-error Protocol types diverge.

tests/PageCollector.test.ts

@@ -340,7 +340,7 @@ describe('ConsoleCollector', () => {
 
     const collector = new ConsoleCollector(browser, collect => {
       return {
-        issue: issue => {
+        devtoolsAggregateddevtoolsAggregatedIssue: issue => {
           collect(issue as DevTools.AggregatedIssue);
         },
       } as ListenerMap;
@@ -361,7 +361,7 @@ describe('ConsoleCollector', () => {
 
     const collector = new ConsoleCollector(browser, collect => {
       return {
-        issue: issue => {
+        devtoolsAggregatedIssue: issue => {
           collect(issue as DevTools.AggregatedIssue);
         },
       } as ListenerMap;
@@ -380,7 +380,7 @@ describe('ConsoleCollector', () => {
     } satisfies Protocol.Audits.InspectorIssue;
 
     cdpSession.emit('Audits.issueAdded', {issue});
-    cdpSession.emit('Audits.issueAdded', {issue: issue2});
+    cdpSession.emit('Audits.issueAdded', {devtoolsAggregatedIssue: issue2});
     const data = collector.getData(page);
     assert.equal(data.length, 2);
   });
@@ -393,7 +393,7 @@ describe('ConsoleCollector', () => {
 
     const collector = new ConsoleCollector(browser, collect => {
       return {
-        issue: issue => {
+        devtoolsAggregatedIssue: issue => {
           collect(issue as DevTools.AggregatedIssue);
         },
       } as ListenerMap;