stable tests

Author: Lightning00Blade

src/McpContext.ts

@@ -465,4 +465,21 @@ export class McpContext implements Context {
 
     return locator.wait();
   }
+
+  /**
+   * We need to ignore favicon request as they make our test flaky
+   */
+  async setUpNetworkCollectorForTesting() {
+    this.#networkCollector = new NetworkCollector(this.browser, collect => {
+      return {
+        request: req => {
+          if (req.url().includes('favicon.ico')) {
+            return;
+          }
+          collect(req);
+        },
+      } as ListenerMap;
+    });
+    await this.#networkCollector.init();
+  }
 }

src/PageCollector.ts

@@ -173,14 +173,19 @@ export class PageCollector<T> {
 }
 
 export class NetworkCollector extends PageCollector<HTTPRequest> {
-  constructor(browser: Browser) {
-    super(browser, collect => {
+  constructor(
+    browser: Browser,
+    listeners: (
+      collector: (item: HTTPRequest) => void,
+    ) => ListenerMap<PageEvents> = collect => {
       return {
         request: req => {
           collect(req);
         },
       } as ListenerMap;
-    });
+    },
+  ) {
+    super(browser, listeners);
   }
   override splitAfterNavigation(page: Page) {
     const navigations = this.storage.get(page) ?? [];

tests/tools/network.test.js.snapshot

@@ -21,7 +21,7 @@ exports[`network > network_list_requests > list requests form current navigation
 # list_request response
 ## Network requests
 Showing 1-1 of 1 (Page 1 of 1).
-reqid=4 GET http://localhost:<port>/three [success - 200]
+reqid=3 GET http://localhost:<port>/three [success - 200]
 `;
 
 exports[`network > network_list_requests > list requests from previous navigations 1`] = `

tests/tools/network.test.ts

@@ -30,6 +30,7 @@ describe('network', () => {
       server.addHtmlRoute('/three', html`<main>Third</main>`);
 
       await withBrowser(async (response, context) => {
+        await context.setUpNetworkCollectorForTesting();
         const page = context.getSelectedPage();
         await page.goto(server.getRoute('/one'));
         await page.goto(server.getRoute('/two'));
@@ -52,6 +53,7 @@ describe('network', () => {
       server.addHtmlRoute('/three', html`<main>Third</main>`);
 
       await withBrowser(async (response, context) => {
+        await context.setUpNetworkCollectorForTesting();
         const page = context.getSelectedPage();
         await page.goto(server.getRoute('/one'));
         await page.goto(server.getRoute('/two'));
@@ -96,12 +98,13 @@ describe('network', () => {
         assert(!response.includeNetworkRequests);
       });
     });
-    it.only('should get request from previous navigations', async t => {
+    it('should get request from previous navigations', async t => {
       server.addHtmlRoute('/one', html`<main>First</main>`);
       server.addHtmlRoute('/two', html`<main>Second</main>`);
       server.addHtmlRoute('/three', html`<main>Third</main>`);
 
       await withBrowser(async (response, context) => {
+        await context.setUpNetworkCollectorForTesting();
         const page = context.getSelectedPage();
         await page.goto(server.getRoute('/one'));
         await page.goto(server.getRoute('/two'));