Exclude fill_form from schema validation lint rule per review

- Revert fill_form API changes (src/tools/input.ts, tests/tools/input.test.ts)
- Rename rule to enforce-zod-schema per reviewer suggestion
- Fix copyright year to 2026
- Add comment explaining .nullable() catches all calls intentionally
- Exclude src/tools/input.ts from the lint rule via ignores

Author: mvanhorn

CONTRIBUTING.md

@@ -145,5 +145,5 @@ export const scenario: TestScenario = {
 
 ## Restrictions on JSON schema
 
-- no .nullable(), no .object() types. Enforced by the `@local/no-zod-nullable-object` ESLint rule.
+- no .nullable(), no .object() types. Enforced by the `@local/enforce-zod-schema` ESLint rule.
 - represent complex object as a short formatted string.

eslint.config.mjs

@@ -138,8 +138,9 @@ export default defineConfig([
   {
     name: 'Tool schema restrictions',
     files: ['src/tools/**/*.ts'],
+    ignores: ['src/tools/input.ts'],
     rules: {
-      '@local/no-zod-nullable-object': 'error',
+      '@local/enforce-zod-schema': 'error',
     },
   },
   {

…int_rules/no-zod-nullable-object-rule.js …/eslint_rules/enforce-zod-schema-rule.jsscripts/eslint_rules/no-zod-nullable-object-rule.js renamed to scripts/eslint_rules/enforce-zod-schema-rule.js scripts/eslint_rules/no-zod-nullable-object-rule.js renamed to scripts/eslint_rules/enforce-zod-schema-rule.js

@@ -1,11 +1,11 @@
 /**
  * @license
- * Copyright 2025 Google LLC
+ * Copyright 2026 Google LLC
  * SPDX-License-Identifier: Apache-2.0
  */
 
 export default {
-  name: 'no-zod-nullable-object',
+  name: 'enforce-zod-schema',
   meta: {
     type: 'problem',
     docs: {
@@ -33,6 +33,9 @@ export default {
 
         const methodName = node.callee.property.name;
 
+        // We don't validate that .nullable() is called on a ZodObject
+        // specifically - this intentionally catches all .nullable() calls
+        // in tool schema files.
         if (methodName === 'nullable') {
           context.report({
             node: node.callee.property,

scripts/eslint_rules/local-plugin.js

@@ -5,11 +5,11 @@
  */
 
 import checkLicenseRule from './check-license-rule.js';
-import noZodNullableObjectRule from './no-zod-nullable-object-rule.js';
+import enforceZodSchemaRule from './enforce-zod-schema-rule.js';
 
 export default {
   rules: {
     'check-license': checkLicenseRule,
-    'no-zod-nullable-object': noZodNullableObjectRule,
+    'enforce-zod-schema': enforceZodSchemaRule,
   },
 };

src/tools/input.ts

@@ -321,25 +321,25 @@ export const fillForm = definePageTool({
   },
   schema: {
     elements: zod
-      .array(zod.string())
-      .describe(
-        'Elements from snapshot to fill out. Each entry is formatted as "uid=value".',
-      ),
+      .array(
+        zod.object({
+          uid: zod.string().describe('The uid of the element to fill out'),
+          value: zod.string().describe('Value for the element'),
+        }),
+      )
+      .describe('Elements from snapshot to fill out.'),
     includeSnapshot: includeSnapshotSchema,
   },
   handler: async (request, response, context) => {
     const page = request.page;
-    for (const entry of request.params.elements) {
-      const separatorIndex = entry.indexOf('=');
-      if (separatorIndex === -1) {
-        throw new Error(
-          `Invalid element format: "${entry}". Expected "uid=value".`,
-        );
-      }
-      const uid = entry.slice(0, separatorIndex);
-      const value = entry.slice(separatorIndex + 1);
+    for (const element of request.params.elements) {
       await context.waitForEventsAfterAction(async () => {
-        await fillFormElement(uid, value, context as McpContext, page);
+        await fillFormElement(
+          element.uid,
+          element.value,
+          context as McpContext,
+          page,
+        );
       });
     }
     response.appendResponseLine(`Successfully filled out the form`);

tests/tools/input.test.ts

@@ -670,7 +670,16 @@ describe('input', () => {
         await fillForm.handler(
           {
             params: {
-              elements: ['1_2=test', '1_4=test2'],
+              elements: [
+                {
+                  uid: '1_2',
+                  value: 'test',
+                },
+                {
+                  uid: '1_4',
+                  value: 'test2',
+                },
+              ],
             },
             page: context.getSelectedMcpPage(),
           },