[Telemetry] Cleanup unnecessary comments

Author: ergunsh

src/telemetry/clearcut-logger.ts

@@ -96,7 +96,6 @@ export class ClearcutLogger {
           },
         });
 
-        // Update persistence
         state.lastActive = new Date().toISOString();
         await this.#persistence.saveState(state);
       }

src/telemetry/watchdog-client.ts

@@ -41,10 +41,9 @@ export class WatchdogClient {
     const spawner = options?.spawn ?? spawn;
     this.#childProcess = spawner(process.execPath, args, {
       stdio: ['pipe', 'ignore', 'ignore'],
-      detached: false, // Keep attached to parent lifecycle generally, but unref to not block exit
+      detached: false,
     });
 
-    // Don't let the watchdog keep the main process alive
     this.#childProcess.unref();
 
     this.#childProcess.on('error', (err) => {

src/telemetry/watchdog/clearcut-sender.ts

@@ -30,13 +30,11 @@ export class ClearcutSender {
     this.transport(enrichedEvent);
   }
 
-  // Public for stubbing in tests
   transport(event: ChromeDevToolsMcpExtension): void {
     logger('Telemetry event', JSON.stringify(event, null, 2));
   }
 
   async sendShutdownEvent(): Promise<void> {
-    // CRITICAL: Do not include flag_usage
     const shutdownEvent: ChromeDevToolsMcpExtension = {
       server_shutdown: {},
     };
@@ -56,8 +54,6 @@ export class ClearcutSender {
       session_id: this.#sessionId,
       app_version: this.#appVersion,
       os_type: this.#osType,
-      // client_info.client_type could be added here if we passed it in constructor or knew it
-      // but strictly following plan, we populate these specific fields.
     };
   }
 }

src/telemetry/watchdog/main.ts

@@ -4,9 +4,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-/**
- * See IMPLEMENTATION_PLAN.md for details
- */
 
 import process from 'node:process';
 import readline from 'node:readline';
@@ -54,12 +51,8 @@ async function main() {
 
   const sender = new ClearcutSender(argv.appVersion, argv.osType as OsType);
 
-  // === Death Detection ===
-  // We rely on Stdin pipe closing to detect parent death.
-  // This works even with `kill -9` on the parent.
   function onParentDeath(reason: string) {
     logger(`Parent death detected (${reason}). Sending shutdown event...`);
-    // We can't await here effectively in all cases, but we try our best.
     sender
       .sendShutdownEvent()
       .then(() => {
@@ -75,10 +68,8 @@ async function main() {
   process.stdin.on('end', () => onParentDeath('stdin end'));
   process.stdin.on('close', () => onParentDeath('stdin close'));
 
-  // Double check disconnection if spawned with IPC channel (not strictly required by plan but good practice)
   process.on('disconnect', () => onParentDeath('ipc disconnect'));
 
-  // === IPC Handling ===
   const rl = readline.createInterface({
     input: process.stdin,
     terminal: false,

tests/telemetry/watchdog-client.test.ts

@@ -19,14 +19,12 @@ describe('WatchdogClient', () => {
   let mockChildProcess: ChildProcess & {stdin: Writable; kill: sinon.SinonStub};
 
   beforeEach(() => {
-    // Mock child process
     const eventEmitter = new EventEmitter();
     const stdin = new Writable({
         write(_chunk, _encoding, callback) {
             callback();
         }
     });
-    // Use stub instead of spy to allow throws()
     sinon.stub(stdin, 'write');
 
     mockChildProcess = Object.assign(eventEmitter, {
@@ -55,11 +53,8 @@ describe('WatchdogClient', () => {
 
     assert.strictEqual(spawnStub.calledOnce, true);
     const args = spawnStub.firstCall.args;
-    // args[0] is process.execPath
-    // args[1] is arguments array
     const cmdArgs = args[1];
 
-    // Check main arg structure - we expect path to main.js as first arg
     assert.match(cmdArgs[0], /watchdog\/main\.js$/);
     assert.strictEqual(cmdArgs.includes('--parent-pid=100'), true);
     assert.strictEqual(cmdArgs.includes('--app-version=1.2.3'), true);

tests/telemetry/watchdog/clearcut-sender.test.ts

@@ -47,16 +47,13 @@ describe('ClearcutSender', () => {
     const sender = new ClearcutSender('1.0.0', OsType.OS_TYPE_MACOS);
     const transportStub = sinon.stub(sender, 'transport');
 
-    // First call -> session uuid-1
     await sender.send({});
     assert.strictEqual(transportStub.lastCall.args[0].session_id, 'uuid-1');
 
-    // Advance time by 23 hours -> should NOT rotate
     clock.tick(23 * 60 * 60 * 1000);
     await sender.send({});
     assert.strictEqual(transportStub.lastCall.args[0].session_id, 'uuid-1');
 
-    // Advance time by 2 hours (total 25h) -> SHOULD rotate
     clock.tick(2 * 60 * 60 * 1000);
     await sender.send({});
     assert.strictEqual(transportStub.lastCall.args[0].session_id, 'uuid-2');