fix: installing chrome through test script

Author: nroscino

.github/workflows/run-tests.yml

@@ -41,12 +41,6 @@ jobs:
         shell: bash
         run: npm ci
 
-      - name: Install Chrome Canary
-        shell: bash
-        run: |
-          CANARY_PATH=$(npx @puppeteer/browsers install chrome@canary --format "{{path}}")
-          echo "CANARY_EXECUTABLE_PATH=$CANARY_PATH" >> $GITHUB_ENV
-
       - name: Build
         run: npm run bundle
         env:

scripts/test.mjs

@@ -7,7 +7,7 @@
 // Note: can be converted to ts file once node 20 support is dropped.
 // Node 20 does not support --experimental-strip-types flag.
 
-import {spawn} from 'node:child_process';
+import {spawn, execSync} from 'node:child_process';
 import path from 'node:path';
 import process from 'node:process';
 
@@ -58,6 +58,15 @@ const nodeArgs = [
   ...files,
 ];
 
+function installChrome(version) {
+  try {
+    return execSync(`npx @puppeteer/browsers install chrome@${version} --format "{{path}}"`).toString().trim();
+  } catch (e) {
+    console.error(`Failed to install Chrome ${version}:`, e);
+    process.exit(1);
+  }
+}
+
 async function runTests(attempt) {
   if (attempt > 1) {
     console.log(`\nRun attempt ${attempt}...\n`);
@@ -78,6 +87,9 @@ async function runTests(attempt) {
   });
 }
 
+const chromePath = installChrome('146.0.7680.31');
+process.env.TRIGGER_ACTION_EXECUTABLE_PATH = chromePath;
+
 const maxAttempts = shouldRetry ? 3 : 1;
 let exitCode = 1;
 

tests/tools/extensions.test.ts

@@ -149,7 +149,7 @@ describe('extension', () => {
         assert.ok(pageTargetAfter, 'Page should exist after action');
       },
       {
-        executablePath: process.env.CANARY_EXECUTABLE_PATH,
+        executablePath: process.env.TRIGGER_ACTION_EXECUTABLE_PATH,
       },
       {
         categoryExtensions: true,