chore: move 'undefined' logic into formatting methods

Author: nroscino

src/McpResponse.ts

@@ -7,7 +7,7 @@ import type {
   ImageContent,
   TextContent,
 } from '@modelcontextprotocol/sdk/types.js';
-import type {HTTPRequest, HTTPResponse, ResourceType} from 'puppeteer-core';
+import type {ResourceType} from 'puppeteer-core';
 
 import {formatConsoleEvent} from './formatters/consoleFormatter.js';
 import {
@@ -144,12 +144,12 @@ export class McpResponse implements Response {
       );
 
       this.#attachedNetworkRequestData.requestBody =
-        await this.processRequestBody(request);
+        await getFormattedRequestBody(request);
 
       const response = request.response();
       if (response) {
         this.#attachedNetworkRequestData.responseBody =
-          await this.processResponseBody(response);
+          await getFormattedResponseBody(response);
       }
     }
 
@@ -166,28 +166,6 @@ export class McpResponse implements Response {
     return this.format(toolName, context);
   }
 
-  async processResponseBody(
-    httpResponse: HTTPResponse,
-  ): Promise<string | undefined> {
-    const formattedResponseData = await getFormattedResponseBody(httpResponse);
-    if (formattedResponseData.length > 0) {
-      return formattedResponseData;
-    }
-
-    return undefined;
-  }
-
-  async processRequestBody(
-    httpRequest: HTTPRequest,
-  ): Promise<string | undefined> {
-    const formattedRequestData = await getFormattedRequestBody(httpRequest);
-    if (formattedRequestData.length > 0) {
-      return formattedRequestData;
-    }
-
-    return undefined;
-  }
-
   format(
     toolName: string,
     context: McpContext,

src/formatters/networkFormatter.ts

@@ -45,7 +45,7 @@ export function getFormattedHeaderValue(
 export async function getFormattedResponseBody(
   httpResponse: HTTPResponse,
   sizeLimit: number = BODY_CONTEXT_SIZE_LIMIT,
-): Promise<string> {
+): Promise<string | undefined> {
   try {
     const responseBuffer = await httpResponse.buffer();
 
@@ -62,14 +62,14 @@ export async function getFormattedResponseBody(
     return `<binary data>`;
   } catch {
     // buffer() call might fail with CDP exception, in this case we don't print anything in the context
-    return '';
+    return undefined;
   }
 }
 
 export async function getFormattedRequestBody(
   httpRequest: HTTPRequest,
   sizeLimit: number = BODY_CONTEXT_SIZE_LIMIT,
-): Promise<string> {
+): Promise<string | undefined> {
   if (httpRequest.hasPostData()) {
     const data = httpRequest.postData();
 
@@ -85,11 +85,11 @@ export async function getFormattedRequestBody(
       }
     } catch {
       // fetchPostData() call might fail with CDP exception, in this case we don't print anything in the context
-      return '';
+      return undefined;
     }
   }
 
-  return '';
+  return undefined;
 }
 
 function getSizeLimitedString(text: string, sizeLimit: number) {

tests/formatters/networkFormatter.test.ts

@@ -122,7 +122,7 @@ describe('networkFormatter', () => {
 
       const result = await getFormattedRequestBody(request, 200);
 
-      assert.strictEqual(result, '');
+      assert.strictEqual(result, undefined);
     });
     it('shows request body when postData is available', async () => {
       const request = getMockRequest({
@@ -173,7 +173,7 @@ describe('networkFormatter', () => {
 
       const result = await getFormattedRequestBody(request, 200);
 
-      assert.strictEqual(result, '');
+      assert.strictEqual(result, undefined);
     });
   });
 
@@ -232,7 +232,7 @@ describe('networkFormatter', () => {
 
       const result = await getFormattedResponseBody(response, 200);
 
-      assert.strictEqual(result, '');
+      assert.strictEqual(result, undefined);
     });
   });
 });