Skip to content

Commit b7b9eb5

Browse files
committed
chore: addressing PR feedbacks
1 parent 5954f66 commit b7b9eb5

4 files changed

Lines changed: 14 additions & 10 deletions

File tree

src/McpContext.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ import type {
4444
GeolocationOptions,
4545
TextSnapshot,
4646
TextSnapshotNode,
47+
ExtensionServiceWorker,
4748
} from './types.js';
4849
import {
4950
ExtensionRegistry,
@@ -58,12 +59,6 @@ export type {
5859
TextSnapshotNode,
5960
} from './types.js';
6061

61-
export interface ExtensionServiceWorker {
62-
url: string;
63-
target: Target;
64-
id: string;
65-
}
66-
6762
interface McpContextOptions {
6863
// Whether the DevTools windows are exposed as pages for debugging of DevTools.
6964
experimentalDevToolsDebugging: boolean;

src/tools/ToolDefinition.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
import type {ParsedArguments} from '../cli.js';
8-
import type {ExtensionServiceWorker} from '../McpContext.js';
98
import {zod} from '../third_party/index.js';
109
import type {
1110
Dialog,
@@ -15,7 +14,11 @@ import type {
1514
Viewport,
1615
} from '../third_party/index.js';
1716
import type {InsightName, TraceResult} from '../trace-processing/parse.js';
18-
import type {TextSnapshotNode, GeolocationOptions} from '../types.js';
17+
import type {
18+
TextSnapshotNode,
19+
GeolocationOptions,
20+
ExtensionServiceWorker,
21+
} from '../types.js';
1922
import type {InstalledExtension} from '../utils/ExtensionRegistry.js';
2023
import type {PaginationOptions} from '../utils/types.js';
2124

src/tools/script.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import type {ExtensionServiceWorker} from '../McpContext.js';
87
import {zod} from '../third_party/index.js';
98
import type {Frame, JSHandle, Page, WebWorker} from '../third_party/index.js';
9+
import type {ExtensionServiceWorker} from '../types.js';
1010

1111
import {ToolCategory} from './categories.js';
1212
import type {Context, Response} from './ToolDefinition.js';

src/types.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,13 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import type {SerializedAXNode, Viewport} from './third_party/index.js';
7+
import type {SerializedAXNode, Viewport, Target} from './third_party/index.js';
8+
9+
export interface ExtensionServiceWorker {
10+
url: string;
11+
target: Target;
12+
id: string;
13+
}
814

915
export interface TextSnapshotNode extends SerializedAXNode {
1016
id: string;

0 commit comments

Comments
 (0)