Skip to content

Commit bff90e6

Browse files
committed
resolveCdpElementId fixes
1 parent 3ca53f8 commit bff90e6

4 files changed

Lines changed: 3 additions & 11 deletions

File tree

src/McpPage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ export class McpPage implements ContextPage {
267267
cdpElementIds.push(`stashed-${i}`);
268268
continue;
269269
}
270-
const cdpElementId = context.resolveCdpElementId(this, backendNodeId);
270+
const cdpElementId = this.resolveCdpElementId(backendNodeId);
271271
if (!cdpElementId) {
272272
logger(`Could not get cdpElementId for backend node ${backendNodeId}`);
273273
cdpElementIds.push(`stashed-${i}`);

src/TextSnapshot.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,7 @@ export class TextSnapshot {
134134
const data = options.devtoolsData ?? (await context.getDevToolsData(page));
135135
if (data?.cdpBackendNodeId) {
136136
snapshot.hasSelectedElement = true;
137-
snapshot.selectedElementUid = context.resolveCdpElementId(
138-
page,
139-
data.cdpBackendNodeId,
140-
);
137+
snapshot.selectedElementUid = page.resolveCdpElementId(data.cdpBackendNodeId);
141138
}
142139

143140
// Clean up unique IDs that we did not see anymore.

src/tools/ToolDefinition.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,6 @@ export type Context = Readonly<{
221221
triggerExtensionAction(id: string): Promise<void>;
222222
listExtensions(): Promise<Map<string, Extension>>;
223223
getExtension(id: string): Promise<Extension | undefined>;
224-
resolveCdpElementId(
225-
page: ContextPage,
226-
cdpBackendNodeId: number,
227-
): string | undefined;
228-
229224
getSelectedMcpPage(): McpPage;
230225
getExtensionServiceWorkers(): ExtensionServiceWorker[];
231226
getExtensionServiceWorkerId(

tests/tools/inPage.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ describe('inPage', () => {
623623
});
624624

625625
const stub = sinon
626-
.stub(context, 'resolveCdpElementId')
626+
.stub(page, 'resolveCdpElementId')
627627
.returns('mock-uid');
628628

629629
await executeInPageTool.handler(

0 commit comments

Comments
 (0)