chore(deps-dev): bump chrome-devtools-frontend from 1.0.1613625 to 1.0.1616061 (#1952)

Closes #1908

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Piotr Paulski <piotrpaulski@chromium.org>

Author: 3 people

package-lock.json

@@ -63,7 +63,7 @@
     "@types/yargs": "^17.0.33",
     "@typescript-eslint/eslint-plugin": "^8.43.0",
     "@typescript-eslint/parser": "^8.43.0",
-    "chrome-devtools-frontend": "1.0.1613625",
+    "chrome-devtools-frontend": "1.0.1618066",
     "core-js": "3.49.0",
     "debug": "4.4.3",
     "eslint": "^9.35.0",

package.json

@@ -52,7 +52,12 @@ export const LOCAL_FETCH_PATTERN = './locales/@LOCALE@.json';`;
   );
   fs.mkdirSync(codeMirrorDir, {recursive: true});
   const codeMirrorFile = path.join(codeMirrorDir, 'codemirror.next.js');
-  const codeMirrorContent = `export default {}`;
+  const codeMirrorContent = `
+export default {};
+export const cssStreamParser = () => Promise.resolve({ startState: () => ({}) });
+export class StringStream { constructor() {} }
+export const css = { cssLanguage: { parser: { parse: () => ({ topNode: { getChild: () => null } }) } } };
+`;
   writeFile(codeMirrorFile, codeMirrorContent);
 
   // Create root mock
@@ -61,7 +66,13 @@ export const LOCAL_FETCH_PATTERN = './locales/@LOCALE@.json';`;
   const runtimeFile = path.join(rootDir, 'Runtime.js');
   const runtimeContent = `
 export function getChromeVersion() { return ''; };
+export function getRemoteBase() { return null; };
 export const hostConfig = {};
+export const GdpProfilesEnterprisePolicyValue = {
+  ENABLED: 0,
+  ENABLED_WITHOUT_BADGES: 1,
+  DISABLED: 2,
+};
 export const Runtime = {
   isDescriptorEnabled: () => true,
   queryParam: () => null,
@@ -94,6 +105,33 @@ export const ExperimentName = {
   `;
   writeFile(runtimeFile, runtimeContent);
 
+  // Copy missing CodeMirror .mjs files that tsc ignores due to .d.mts renames
+  const codemirrorDir = path.join(
+    BUILD_DIR,
+    devtoolsThirdPartyPath,
+    'codemirror',
+  );
+  const codemirrorSrcDir = path.join(
+    process.cwd(),
+    'node_modules',
+    'chrome-devtools-frontend',
+    'front_end',
+    'third_party',
+    'codemirror',
+  );
+  const filesToCopy = [
+    'package/addon/runmode/runmode-standalone.mjs',
+    'package/mode/css/css.mjs',
+    'package/mode/javascript/javascript.mjs',
+    'package/mode/xml/xml.mjs',
+  ];
+  for (const file of filesToCopy) {
+    const src = path.join(codemirrorSrcDir, file);
+    const dest = path.join(codemirrorDir, file);
+    fs.mkdirSync(path.dirname(dest), {recursive: true});
+    fs.copyFileSync(src, dest);
+  }
+
   copyDevToolsDescriptionFiles();
 }
 

scripts/post-build.ts

@@ -165,7 +165,10 @@ export class McpContext implements Context {
     this.#roots = roots;
   }
 
-  validatePath(filePath: string): void {
+  validatePath(filePath?: string): void {
+    if (filePath === undefined) {
+      return;
+    }
     const roots = this.roots();
     if (roots === undefined) {
       return;
@@ -676,7 +679,11 @@ export class McpContext implements Context {
   ): Promise<{filepath: string}> {
     const filepath = await getTempFilePath(filename);
     this.validatePath(filepath);
-    await fs.writeFile(filepath, data);
+    try {
+      await fs.writeFile(filepath, data);
+    } catch (err) {
+      throw new Error('Could not save a file', {cause: err});
+    }
     return {filepath};
   }
 

src/McpContext.ts

@@ -170,7 +170,7 @@ export type SupportedExtensions =
  * Only add methods used by tools/*.
  */
 export type Context = Readonly<{
-  validatePath(filePath: string): void;
+  validatePath(filePath?: string): void;
   isRunningPerformanceTrace(): boolean;
   setIsRunningPerformanceTrace(x: boolean): void;
   isCruxEnabled(): boolean;

src/tools/ToolDefinition.ts

@@ -53,9 +53,7 @@ export const lighthouseAudit = definePageTool({
       outputDirPath,
     } = request.params;
 
-    if (outputDirPath) {
-      context.validatePath(outputDirPath);
-    }
+    context.validatePath(outputDirPath);
 
     const flags: Flags = {
       onlyCategories: categories,

src/tools/lighthouse.ts

@@ -114,12 +114,8 @@ export const getNetworkRequest = definePageTool({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.requestFilePath) {
-      context.validatePath(request.params.requestFilePath);
-    }
-    if (request.params.responseFilePath) {
-      context.validatePath(request.params.responseFilePath);
-    }
+    context.validatePath(request.params.requestFilePath);
+    context.validatePath(request.params.responseFilePath);
     if (request.params.reqid) {
       response.attachNetworkRequest(request.params.reqid, {
         requestFilePath: request.params.requestFilePath,

src/tools/network.ts

@@ -49,9 +49,7 @@ export const startTrace = definePageTool({
     filePath: filePathSchema,
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (context.isRunningPerformanceTrace()) {
       response.appendResponseLine(
         'Error: a performance trace is already running. Use performance_stop_trace to stop it. Only one trace can be running at any given time.',
@@ -129,9 +127,7 @@ export const stopTrace = definePageTool({
     filePath: filePathSchema,
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (!context.isRunningPerformanceTrace()) {
       return;
     }

src/tools/performance.ts

@@ -40,9 +40,7 @@ export const startScreencast = definePageTool(args => ({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (context.getScreenRecorder() !== null) {
       response.appendResponseLine(
         'Error: a screencast recording is already in progress. Use screencast_stop to stop it before starting a new one.',

src/tools/screencast.ts

@@ -51,9 +51,7 @@ export const screenshot = definePageTool({
       ),
   },
   handler: async (request, response, context) => {
-    if (request.params.filePath) {
-      context.validatePath(request.params.filePath);
-    }
+    context.validatePath(request.params.filePath);
     if (request.params.uid && request.params.fullPage) {
       throw new Error('Providing both "uid" and "fullPage" is not allowed.');
     }