Skip to content

Commit cf285d8

Browse files
committed
Fix format
1 parent 8a1905f commit cf285d8

8 files changed

Lines changed: 44 additions & 28 deletions

File tree

src/logger.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export function saveLogsToFileSync(fileName: string): void {
3838
let fd: number | undefined;
3939
try {
4040
fd = fs.openSync(fileName, 'a+');
41-
} catch (error: any) {
41+
} catch (error) {
4242
console.error(`Error when opening log file: ${error.message}`);
4343
process.exit(1);
4444
}
@@ -48,7 +48,6 @@ export function saveLogsToFileSync(fileName: string): void {
4848
try {
4949
fs.writeSync(fd, `${chunks.join(' ')}\n`);
5050
} catch (e) {
51-
5251
}
5352
}
5453
};

src/telemetry/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export interface ChromeDevToolsMcpExtension {
1616
server_shutdown?: ServerShutdown;
1717
}
1818

19-
export interface ServerShutdown {}
19+
export type ServerShutdown = Record<string, never>;
2020

2121
export interface ToolInvocation {
2222
tool_name: string;

src/telemetry/watchdog/main.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import yargs from 'yargs';
1212
import {hideBin} from 'yargs/helpers';
1313

1414
import {logger, saveLogsToFileSync} from '../../logger.js';
15-
import {IpcMessageType, OsType} from '../types.js';
15+
import type { OsType} from '../types.js';
16+
import {IpcMessageType} from '../types.js';
1617

1718
import {ClearcutSender} from './clearcut-sender.js';
1819

@@ -83,7 +84,7 @@ async function main() {
8384

8485
rl.on('line', (line) => {
8586
try {
86-
if (!line.trim()) return;
87+
if (!line.trim()) {return;}
8788

8889
const msg = JSON.parse(line);
8990
if (msg.type === IpcMessageType.EVENT && msg.payload) {

tests/e2e/fixtures/server-fixture.ts

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,23 @@
11

2-
import {hideBin} from 'yargs/helpers';
3-
import yargs from 'yargs';
2+
/**
3+
* @license
4+
* Copyright 2026 Google LLC
5+
* SPDX-License-Identifier: Apache-2.0
6+
*/
7+
48
import process from 'node:process';
5-
import {ClearcutLogger} from '../../../src/telemetry/clearcut-logger.js';
9+
10+
import yargs from 'yargs';
11+
import {hideBin} from 'yargs/helpers';
12+
613
import {saveLogsToFile} from '../../../src/logger.js';
14+
import {ClearcutLogger} from '../../../src/telemetry/clearcut-logger.js';
715

816
async function main() {
917
const argv = await yargs(hideBin(process.argv))
1018
.option('action', {
1119
type: 'string',
12-
choices: ['exit-0', 'exit-1', 'crash', 'stay-alive'],
20+
choices: ['exit-0', 'exit-1', 'crash'],
1321
demandOption: true,
1422
})
1523
.option('log-file', {
@@ -44,10 +52,6 @@ async function main() {
4452
case 'crash':
4553
console.log('Crashing');
4654
throw new Error('Planned crash');
47-
case 'stay-alive':
48-
console.log('Staying alive');
49-
setInterval(() => {}, 1000); // Keep alive
50-
break;
5155
}
5256
}, 1000);
5357
}

tests/e2e/telemetry.test.ts

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import {describe, it} from 'node:test';
87
import assert from 'node:assert';
98
import {spawn} from 'node:child_process';
109
import fs from 'node:fs';
11-
import path from 'node:path';
1210
import os from 'node:os';
11+
import path from 'node:path';
12+
import {describe, it} from 'node:test';
1313

1414
describe('Telemetry E2E', () => {
1515
async function runTelemetryTest(signal: NodeJS.Signals) {
@@ -78,7 +78,7 @@ describe('Telemetry E2E', () => {
7878
const checkInterval = setInterval(() => {
7979
try {
8080
process.kill(watchdogPid!, 0); // Check if running
81-
} catch (e) {
81+
} catch {
8282
clearInterval(checkInterval);
8383
resolve();
8484
return;
@@ -87,7 +87,11 @@ describe('Telemetry E2E', () => {
8787

8888
setTimeout(() => {
8989
clearInterval(checkInterval);
90-
try { process.kill(watchdogPid!, 'SIGKILL'); } catch {}
90+
try {
91+
process.kill(watchdogPid!, 'SIGKILL');
92+
} catch {
93+
// no-op
94+
}
9195
reject(new Error('Timeout waiting for Watchdog exit'));
9296
}, 5000);
9397
});
@@ -102,7 +106,7 @@ describe('Telemetry E2E', () => {
102106
console.log(`[${signal}] Shutdown events verified`);
103107

104108
// Cleanup
105-
if (fs.existsSync(logFile)) fs.unlinkSync(logFile);
109+
if (fs.existsSync(logFile)) {fs.unlinkSync(logFile);}
106110
}
107111

108112
async function runFixtureTest(action: 'exit-0' | 'exit-1' | 'crash') {
@@ -165,7 +169,7 @@ describe('Telemetry E2E', () => {
165169
const checkInterval = setInterval(() => {
166170
try {
167171
process.kill(watchdogPid!, 0);
168-
} catch (e) {
172+
} catch {
169173
clearInterval(checkInterval);
170174
resolve();
171175
return;
@@ -174,7 +178,11 @@ describe('Telemetry E2E', () => {
174178

175179
setTimeout(() => {
176180
clearInterval(checkInterval);
177-
try { process.kill(watchdogPid!, 'SIGKILL'); } catch {}
181+
try {
182+
process.kill(watchdogPid!, 'SIGKILL');
183+
} catch {
184+
// no-op
185+
}
178186
reject(new Error('Timeout waiting for Watchdog exit'));
179187
}, 5000);
180188
});
@@ -187,7 +195,7 @@ describe('Telemetry E2E', () => {
187195
assert.match(contentAfter, /server_shutdown/);
188196
console.log(`[${action}] Shutdown events verified`);
189197

190-
if (fs.existsSync(logFile)) fs.unlinkSync(logFile);
198+
if (fs.existsSync(logFile)) {fs.unlinkSync(logFile);}
191199
}
192200

193201
it('handles clean exit (process.exit(0))', () => runFixtureTest('exit-0'));

tests/telemetry/clearcut-logger.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import {describe, it, afterEach, beforeEach} from 'node:test';
1010
import sinon from 'sinon';
1111

1212
import {ClearcutLogger} from '../../src/telemetry/clearcut-logger.js';
13-
import {WatchdogClient} from '../../src/telemetry/watchdog-client.js';
1413
import type {Persistence} from '../../src/telemetry/persistence.js';
1514
import {FilePersistence} from '../../src/telemetry/persistence.js';
1615
import {IpcMessageType} from '../../src/telemetry/types.js';
16+
import {WatchdogClient} from '../../src/telemetry/watchdog-client.js';
1717

1818
describe('ClearcutLogger', () => {
1919
let mockPersistence: sinon.SinonStubbedInstance<Persistence>;

tests/telemetry/watchdog-client.test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,17 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
import {describe, it, afterEach, beforeEach} from 'node:test';
87
import assert from 'node:assert';
9-
import sinon from 'sinon';
10-
import {spawn, type ChildProcess} from 'node:child_process';
8+
import type {spawn} from 'node:child_process';
9+
import { type ChildProcess} from 'node:child_process';
1110
import EventEmitter from 'node:events';
1211
import {Writable} from 'node:stream';
12+
import {describe, it, afterEach, beforeEach} from 'node:test';
13+
14+
import sinon from 'sinon';
1315

14-
import {WatchdogClient} from '../../src/telemetry/watchdog-client.js';
1516
import {OsType, IpcMessageType} from '../../src/telemetry/types.js';
17+
import {WatchdogClient} from '../../src/telemetry/watchdog-client.js';
1618

1719
describe('WatchdogClient', () => {
1820
let spawnStub: sinon.SinonStub;

tests/telemetry/watchdog/clearcut-sender.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,12 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7+
import assert from 'node:assert';
78
import crypto from 'node:crypto';
8-
import sinon from 'sinon';
99
import {describe, it, afterEach, beforeEach} from 'node:test';
10-
import assert from 'node:assert';
10+
11+
import sinon from 'sinon';
12+
1113
import {OsType} from '../../../src/telemetry/types.js';
1214
import {ClearcutSender} from '../../../src/telemetry/watchdog/clearcut-sender.js';
1315

0 commit comments

Comments
 (0)