Skip to content

Commit de66b44

Browse files
committed
ensureCrux for test
Change-Id: I94c55d08bad7c58b28a5febccdc126dc0b012e5f
1 parent 1f17741 commit de66b44

2 files changed

Lines changed: 13 additions & 14 deletions

File tree

src/utils/crux.ts

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -183,19 +183,16 @@ export async function populateCruxData(
183183
parsedTrace: DevTools.TraceEngine.TraceModel.ParsedTrace,
184184
): Promise<void> {
185185
ensureCrUXManager();
186-
try {
187-
const settings = DevTools.Common.Settings.Settings.instance();
188-
const cruxSetting = settings.createSetting<ConfigSetting>(
189-
'field-data',
190-
{enabled: false},
191-
DevTools.Common.Settings.SettingStorageType.GLOBAL,
192-
);
193-
194-
if (!cruxSetting.get().enabled) {
195-
return;
196-
}
197-
} catch {
198-
// Fallback if settings are not available
186+
187+
const settings = DevTools.Common.Settings.Settings.instance();
188+
const cruxSetting = settings.createSetting(
189+
'field-data',
190+
{enabled: true},
191+
DevTools.Common.Settings.SettingStorageType.GLOBAL,
192+
);
193+
194+
if (!cruxSetting.get().enabled) {
195+
return;
199196
}
200197

201198
const urls = new Set<string>();

tests/utils/crux.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66

77
import assert from 'node:assert';
8-
import {describe, it, afterEach} from 'node:test';
8+
import {describe, it, afterEach, before} from 'node:test';
99

1010
import sinon from 'sinon';
1111

@@ -20,6 +20,8 @@ import {ensureCrUXManager} from '../../src/utils/crux.js';
2020
import {loadTraceAsBuffer} from '../trace-processing/fixtures/load.js';
2121

2222
describe('crux util', () => {
23+
before(() => ensureCrUXManager());
24+
2325
afterEach(() => {
2426
sinon.restore();
2527
});

0 commit comments

Comments
 (0)