We have a testing blind spot: it is possible to include an import to a npm module directly bypassing the third_party/index.js which means the import will fail once bundled. Although we test the bundle, our dev dependencies are still present in the test environment (and they are need for tests themselves).
We should have an eslint rule for this + better that our e2e test runs in a separate folder where we unpack npm package that we previously packed with npm pack.
Example of this is #1111 (found through manual release testing with npm pack)
cc @zyzyzyryxy @Lightning00Blade
We have a testing blind spot: it is possible to include an import to a npm module directly bypassing the third_party/index.js which means the import will fail once bundled. Although we test the bundle, our dev dependencies are still present in the test environment (and they are need for tests themselves).
We should have an eslint rule for this + better that our e2e test runs in a separate folder where we unpack npm package that we previously packed with
npm pack.Example of this is #1111 (found through manual release testing with
npm pack)cc @zyzyzyryxy @Lightning00Blade