From 86a26a50eec676ac602bcc8860734ecb7cdf83a3 Mon Sep 17 00:00:00 2001 From: Piotr Paulski Date: Fri, 16 Jan 2026 15:27:22 +0000 Subject: [PATCH 1/2] Fix: Update eslint rule to require empty line after license notice. --- scripts/eslint_rules/check-license-rule.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/scripts/eslint_rules/check-license-rule.js b/scripts/eslint_rules/check-license-rule.js index 9c3041260..2c6c2cde1 100644 --- a/scripts/eslint_rules/check-license-rule.js +++ b/scripts/eslint_rules/check-license-rule.js @@ -24,6 +24,7 @@ export default { schema: [], messages: { licenseRule: 'Add license header.', + emptyLine: 'Add empty line after license header.', }, }, defaultOptions: [], @@ -64,6 +65,22 @@ export default { header.value.includes('License') || header.value.includes('Copyright')) ) { + const nextToken = sourceCode.getTokenAfter(header, { + includeComments: true, + }); + if ( + nextToken && + nextToken.loc.start.line === header.loc.end.line + 1 + ) { + context.report({ + node: node, + loc: header.loc, + messageId: 'emptyLine', + fix(fixer) { + return fixer.insertTextAfter(header, '\n'); + }, + }); + } return; } From 3b7a7a63027d5c403a41ec65dd369eee8c511d1f Mon Sep 17 00:00:00 2001 From: Piotr Paulski Date: Fri, 16 Jan 2026 15:30:46 +0000 Subject: [PATCH 2/2] Fix missing empty lines after license notices. --- rollup.config.mjs | 1 + scripts/eval_scenarios/console_test.ts | 1 + scripts/eval_scenarios/emulation_test.ts | 1 + scripts/eval_scenarios/input_test.ts | 1 + scripts/eval_scenarios/navigation_test.ts | 1 + scripts/eval_scenarios/network_test.ts | 1 + scripts/eval_scenarios/performance_test.ts | 1 + scripts/eval_scenarios/snapshot_test.ts | 1 + src/formatters/SnapshotFormatter.ts | 1 + src/tools/console.ts | 1 + src/tools/tools.ts | 1 + 11 files changed, 11 insertions(+) diff --git a/rollup.config.mjs b/rollup.config.mjs index 957952de9..f3c302b31 100644 --- a/rollup.config.mjs +++ b/rollup.config.mjs @@ -14,6 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + /** * @fileoverview take from {@link https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/rollup.config.mjs | chromium-bidi} * and modified to specific requirement. diff --git a/scripts/eval_scenarios/console_test.ts b/scripts/eval_scenarios/console_test.ts index 803171d4d..94ce4da92 100644 --- a/scripts/eval_scenarios/console_test.ts +++ b/scripts/eval_scenarios/console_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/emulation_test.ts b/scripts/eval_scenarios/emulation_test.ts index 94c34e846..4b6f01c81 100644 --- a/scripts/eval_scenarios/emulation_test.ts +++ b/scripts/eval_scenarios/emulation_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/input_test.ts b/scripts/eval_scenarios/input_test.ts index b359884de..ca1e28d25 100644 --- a/scripts/eval_scenarios/input_test.ts +++ b/scripts/eval_scenarios/input_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/navigation_test.ts b/scripts/eval_scenarios/navigation_test.ts index 6942ab565..7619b686a 100644 --- a/scripts/eval_scenarios/navigation_test.ts +++ b/scripts/eval_scenarios/navigation_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/network_test.ts b/scripts/eval_scenarios/network_test.ts index e1ace21e1..480c3ec7b 100644 --- a/scripts/eval_scenarios/network_test.ts +++ b/scripts/eval_scenarios/network_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/performance_test.ts b/scripts/eval_scenarios/performance_test.ts index c7c7ae2b2..63ab32204 100644 --- a/scripts/eval_scenarios/performance_test.ts +++ b/scripts/eval_scenarios/performance_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/scripts/eval_scenarios/snapshot_test.ts b/scripts/eval_scenarios/snapshot_test.ts index c5f43ff55..4877c1d1b 100644 --- a/scripts/eval_scenarios/snapshot_test.ts +++ b/scripts/eval_scenarios/snapshot_test.ts @@ -3,6 +3,7 @@ * Copyright 2026 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import assert from 'node:assert'; import type {TestScenario} from '../eval_gemini.ts'; diff --git a/src/formatters/SnapshotFormatter.ts b/src/formatters/SnapshotFormatter.ts index dabd937e7..e24c99df4 100644 --- a/src/formatters/SnapshotFormatter.ts +++ b/src/formatters/SnapshotFormatter.ts @@ -3,6 +3,7 @@ * Copyright 2025 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import type {TextSnapshot, TextSnapshotNode} from '../McpContext.js'; export class SnapshotFormatter { diff --git a/src/tools/console.ts b/src/tools/console.ts index 9c3d145bb..ace8f6282 100644 --- a/src/tools/console.ts +++ b/src/tools/console.ts @@ -3,6 +3,7 @@ * Copyright 2025 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import {zod} from '../third_party/index.js'; import type {ConsoleMessageType} from '../third_party/index.js'; diff --git a/src/tools/tools.ts b/src/tools/tools.ts index 227fb0d42..f28ff4459 100644 --- a/src/tools/tools.ts +++ b/src/tools/tools.ts @@ -3,6 +3,7 @@ * Copyright 2025 Google LLC * SPDX-License-Identifier: Apache-2.0 */ + import * as consoleTools from './console.js'; import * as emulationTools from './emulation.js'; import * as inputTools from './input.js';