From e413eaebc3cae2980de74d176c6b930aacb9f91c Mon Sep 17 00:00:00 2001 From: Ergun Erdogmus Date: Mon, 19 Jan 2026 15:20:33 +0100 Subject: [PATCH] chore: Prefix logged enum flag values with their snake_case name --- src/telemetry/flag-utils.ts | 2 +- tests/telemetry/flag-utils.test.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/telemetry/flag-utils.ts b/src/telemetry/flag-utils.ts index 2ff3f761a..525ac4817 100644 --- a/src/telemetry/flag-utils.ts +++ b/src/telemetry/flag-utils.ts @@ -52,7 +52,7 @@ export function computeFlagUsage( // For enums, log the value as uppercase // We're going to have an enum for such flags with choices represented // as an `enum` where the keys of the enum will map to the uppercase `choice`. - usage[snakeCaseName] = value.toUpperCase(); + usage[snakeCaseName] = `${snakeCaseName}_${value}`.toUpperCase(); } } diff --git a/tests/telemetry/flag-utils.test.ts b/tests/telemetry/flag-utils.test.ts index cf1cbfb4e..f7105ce14 100644 --- a/tests/telemetry/flag-utils.test.ts +++ b/tests/telemetry/flag-utils.test.ts @@ -44,10 +44,10 @@ describe('computeFlagUsage', () => { assert.equal(usage.bool_flag, false); }); - it('logs enum flags as uppercase', () => { + it('logs enum flags as uppercase strings prefixed by snake case flag name', () => { const args = {enumFlag: 'a'}; const usage = computeFlagUsage(args, mockOptions); - assert.equal(usage.enum_flag, 'A'); + assert.equal(usage.enum_flag, 'ENUM_FLAG_A'); }); it('logs other flags as present with snake_case keys', () => {