test(Container): name the nested-inheritance spec in BDD style#1069
Merged
Conversation
The `describe`/`it` for the custom-property inheritance guard read as
implementation labels ("child Container does not inherit …") rather than a
sentence. Rename them to natural-language BDD per the bdd-tests convention, so
the full path reads "isolating layout custom properties from nested Containers
› does not let a nested Container inherit its ancestor's fillHeight, grow, or
overflow". No behavior change — only the test names.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-oosnpamxs-clickhouse.vercel.app Built from commit: |
hoorayimhelping
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @hoorayimhelping's review nit on #1067: the nested-inheritance guard's
describe/itread as implementation labels rather than a sentence.Before
After (reads as natural-language BDD, per control-plane's
bdd-testsconvention)No behavior change — only the
describe/itstrings. The test still passes:🤖 Generated with Claude Code
Note
Low Risk
Test-only rename of describe/it strings; no production or assertion changes.
Overview
Renames the nested Container layout test’s
describeandittitles so they read as natural-language BDD (aligned with control-plane’sbdd-testsconvention) instead of implementation-style labels.No test logic or assertions change — only the strings shown in test output.
Reviewed by Cursor Bugbot for commit ee21a47. Bugbot is set up for automated code reviews on this repo. Configure here.