Skip to content

funcSig feature fails when having methods with structs as arguments #155

@0xdcota

Description

@0xdcota

With a simple method as show below:

function enableBorrowingOnReserve(address asset, bool stableBorrowRateEnabled) external onlyPoolAdmin

The funcSig feature returns a new file with:

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 
| enableBorrowingOnReserve | eede87c1 | enableBorrowingOnReserve(address,bool) |

The above is great 👍

Now, the issue is

However, with a complex argument function such as:

function updateAToken(UpdateATokenInput calldata input) external onlyPoolAdmin

The funcSig returns nothing.. ❌

| Function Name | Sighash    | Function Signature | 
| ------------- | ---------- | ------------------ | 

I suppose the challenge is in interpreting: "what is UpdateATokenInput".

The methods above are in the Aave code base if you want to give it a try: https://github.com/aave/protocol-v2/blob/master/contracts/protocol/lendingpool/LendingPoolConfigurator.sol

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions