fix!: generate stable IDs to avoid orphaned aliases in Command Palette (#50)

Author: Testudinidae

CmdPalWebSearchShortcut/WebSearchShortcut/Pages/AddShortcutPage.cs

@@ -16,6 +16,8 @@ public AddShortcutPage(WebSearchShortcutDataEntry? shortcut)
         var isAdd = string.IsNullOrEmpty(name) && string.IsNullOrEmpty(url);
 
         _addShortcutForm = new AddShortcutForm(shortcut);
+
+        Id = "WebSearchShortcut.AddShortcut";
         Icon = IconHelpers.FromRelativePath("Assets\\SearchAdd.png");
         Title = isAdd ? Resources.AddShortcut_AddTitle : Resources.SearchShortcut_EditTitle;
         Name = isAdd ? Resources.AddShortcut_AddName : Resources.SearchShortcut_EditName;

CmdPalWebSearchShortcut/WebSearchShortcut/Pages/SearchWebPage.cs

@@ -27,6 +27,7 @@ public SearchWebPage(WebSearchShortcutDataEntry shortcut)
     {
         _shortcut = shortcut;
 
+        Id = shortcut.Id;
         Name = shortcut.Name;
         Icon = IconService.GetIconInfo(shortcut);
         _openHomePageItem = new ListItem(new OpenHomePageCommand(shortcut))

CmdPalWebSearchShortcut/WebSearchShortcut/Storage.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Text.Json;
@@ -47,6 +48,12 @@ public static Storage ReadFromFile(string path)
             if (!string.IsNullOrEmpty(jsonStringReading))
             {
                 data = JsonSerializer.Deserialize(jsonStringReading, AppJsonSerializerContext.Default.Storage) ?? new Storage();
+
+                bool modified = EnsureIds(data.Data);
+                if (modified)
+                {
+                    WriteToFile(path, data);
+                }
             }
         }
 
@@ -55,8 +62,38 @@ public static Storage ReadFromFile(string path)
 
     public static void WriteToFile(string path, Storage data)
     {
+        EnsureIds(data.Data);
+
         var jsonString = JsonPrettyFormatter.ToPrettyJson(data, AppJsonSerializerContext.Default.Storage);
 
         File.WriteAllText(path, jsonString);
     }
+
+    private static bool EnsureIds(List<WebSearchShortcutDataEntry> shortcuts)
+    {
+        bool modified = false;
+        HashSet<string> existingIds = [];
+
+        foreach (var shortcut in shortcuts)
+        {
+            while (string.IsNullOrWhiteSpace(shortcut.Id) || existingIds.Contains(shortcut.Id))
+            {
+                modified = true;
+
+                shortcut.Id = GenerateId();
+            }
+            existingIds.Add(shortcut.Id);
+        }
+
+        return modified;
+    }
+
+    private static string GenerateId()
+    {
+        byte[] buffer = new byte[8];
+        Random.Shared.NextBytes(buffer);
+        ulong randomNumber = BitConverter.ToUInt64(buffer, 0);
+
+        return $"WebSearchShortcut{randomNumber}";
+    }
 }

CmdPalWebSearchShortcut/WebSearchShortcut/WebSearchShortcutDataEntry.cs

@@ -6,6 +6,7 @@ namespace WebSearchShortcut;
 
 internal sealed class WebSearchShortcutDataEntry
 {
+    public string Id { get; set; } = string.Empty;
     public string Name { get; set; } = string.Empty;
     public string? Keyword { get; set; }
     public string Url { get; set; } = string.Empty;