Don't use reserved words as route parameter names. close #37

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP008ValidRouteParameterNameTests/CodeFix.cs

@@ -49,5 +49,31 @@ public IActionResult GetId(string id)
 }".AssertReplace("\"api/orders/{id}\"", after);
             AnalyzerAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, code, fixedCode);
         }
+
+        [TestCase("\"api/orders/{↓action}\"")]
+        [TestCase("\"api/orders/{↓area}\"")]
+        [TestCase("\"api/orders/{↓controller}\"")]
+        [TestCase("\"api/orders/{↓handler}\"")]
+        [TestCase("\"api/orders/{↓page}\"")]
+        public void NoFixWhen(string before)
+        {
+            var code = @"
+namespace ValidCode
+{
+    using Microsoft.AspNetCore.Mvc;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        [HttpGet(""api/orders/{id}"")]
+        public IActionResult GetId(string id)
+        {
+            return this.Ok(id);
+        }
+    }
+}".AssertReplace("\"api/orders/{id}\"", before);
+
+            AnalyzerAssert.NoFix(Analyzer, Fix, ExpectedDiagnostic, code);
+        }
     }
 }

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -504,6 +504,17 @@ private static bool HasInvalidName(PathSegment segment, out Location location, o
                     correctName = parameter.Name.ToString().Trim();
                     return true;
                 }
+
+                if (parameter.Name.Equals("action", StringComparison.OrdinalIgnoreCase) ||
+                    parameter.Name.Equals("area", StringComparison.OrdinalIgnoreCase) ||
+                    parameter.Name.Equals("controller", StringComparison.OrdinalIgnoreCase) ||
+                    parameter.Name.Equals("handler", StringComparison.OrdinalIgnoreCase) ||
+                    parameter.Name.Equals("page", StringComparison.OrdinalIgnoreCase))
+                {
+                    location = parameter.Name.GetLocation();
+                    correctName = null;
+                    return true;
+                }
             }
 
             location = null;