More tests.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP002MissingParameterTests/CodeFix.cs

@@ -30,6 +30,116 @@ public class OrdersController : Controller
             AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
         }
 
+        [Test]
+        public void WhenLastIsMissing()
+        {
+            var order = @"
+namespace ValidCode
+{
+    public class Order
+    {
+        public int Id { get; set; }
+    }
+}";
+
+            var db = @"
+namespace ValidCode
+{
+    using Microsoft.EntityFrameworkCore;
+
+    public class Db : DbContext
+    {
+        public DbSet<Order> Orders { get; set; }
+    }
+}";
+            var code = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{orderId}/items/{itemId}"")]
+        public async Task<IActionResult> GetOrder↓(int orderId)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == orderId);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, order, db, code);
+        }
+
+        [Test]
+        public void WhenFirstIsMissing()
+        {
+            var order = @"
+namespace ValidCode
+{
+    public class Order
+    {
+        public int Id { get; set; }
+    }
+}";
+
+            var db = @"
+namespace ValidCode
+{
+    using Microsoft.EntityFrameworkCore;
+
+    public class Db : DbContext
+    {
+        public DbSet<Order> Orders { get; set; }
+    }
+}";
+            var code = @"
+namespace ValidCode
+{
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.EntityFrameworkCore;
+
+    [ApiController]
+    public class OrdersController : Controller
+    {
+        private readonly Db db;
+
+        public OrdersController(Db db)
+        {
+            this.db = db;
+        }
+
+        [HttpGet(""api/orders/{orderId}/items/{itemId}"")]
+        public async Task<IActionResult> GetOrder↓(int itemId)
+        {
+            var match = await this.db.Orders.FirstOrDefaultAsync(x => x.Id == itemId);
+            if (match == null)
+            {
+                return this.NotFound();
+            }
+
+            return this.Ok(match);
+        }
+    }
+}";
+            AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, order, db, code);
+        }
+
         [TestCase("[FromHeader]")]
         [TestCase("[FromBody]")]
         public void WhenWrongAttribute(string attribute)

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -52,8 +52,7 @@ context.ContainingSymbol is IMethodSymbol method &&
                                 methodDeclaration.ParameterList.GetLocation()));
                     }
 
-                    if (pairs.TrySingle(x => x.Template != null, out _) &&
-                        pairs.TrySingle(x => x.Method == null, out _))
+                    if (pairs.TryFirst(x => x.Method == null, out _))
                     {
                         context.ReportDiagnostic(
                             Diagnostic.Create(