Don't use Span.Text

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/Helpers/UrlTemplateTests.cs

@@ -28,7 +28,7 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
 }".AssertReplace("api/orders/{id}", text));
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
-            CollectionAssert.AreEqual(expected, template.Path.Select(x => x.Span.Text));
+            CollectionAssert.AreEqual(expected, template.Path.Select(x => x.Span.ToString()));
         }
 
         [TestCase("{id}",                 new[] { "{id}" })]
@@ -57,12 +57,12 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
 }".AssertReplace("api/orders/{id}", text));
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
-            CollectionAssert.AreEqual(expected, template.Path.Select(x => x.Span.Text));
+            CollectionAssert.AreEqual(expected, template.Path.Select(x => x.Span.ToString()));
 
             // ReSharper disable once PossibleInvalidOperationException
             var parameter = template.Path.Single(x => x.Parameter.HasValue)
                                     .Parameter.Value;
-            Assert.AreEqual("id", parameter.Name.Text);
+            Assert.AreEqual("id", parameter.Name.ToString());
         }
 
         [TestCase("orders/{id?}",                  new[] { "orders", "{id?}" },                  new[] { "?" })]
@@ -90,13 +90,13 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
 }".AssertReplace("orders/{id}", text));
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
-            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.Text));
+            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.ToString()));
 
             // ReSharper disable once PossibleInvalidOperationException
             var parameter = template.Path.Single(x => x.Parameter.HasValue)
                                     .Parameter.Value;
-            Assert.AreEqual("id", parameter.Name.Text);
-            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.Text));
+            Assert.AreEqual("id", parameter.Name.ToString());
+            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.ToString()));
         }
 
         [TestCase("orders/{id}",                                         new[] { "orders", "{id}" },                                   new string[0])]
@@ -131,13 +131,13 @@ public async Task<IActionResult> GetOrder(string id)
 }".AssertReplace("orders/{id}", text));
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
-            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.Text));
+            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.ToString()));
 
             // ReSharper disable once PossibleInvalidOperationException
             var parameter = template.Path.Single(x => x.Parameter.HasValue)
                                     .Parameter.Value;
-            Assert.AreEqual("id", parameter.Name.Text);
-            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.Text)
+            Assert.AreEqual("id", parameter.Name.ToString());
+            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.ToString())
                                                             .ToArray());
         }
 
@@ -163,13 +163,13 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
 }".AssertReplace("orders/{id}", text));
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
-            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.Text));
+            CollectionAssert.AreEqual(segments, template.Path.Select(x => x.Span.ToString()));
 
             // ReSharper disable once PossibleInvalidOperationException
             var parameter = template.Path.Single(x => x.Parameter.HasValue)
                                     .Parameter.Value;
-            Assert.AreEqual("id", parameter.Name.Text);
-            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.Text));
+            Assert.AreEqual("id", parameter.Name.ToString());
+            CollectionAssert.AreEqual(constraints, parameter.Constraints.Select(x => x.Span.ToString()));
         }
     }
 }

AspNetCoreAnalyzers/Helpers/Span.cs

@@ -1,12 +1,10 @@
 namespace AspNetCoreAnalyzers
 {
     using System;
-    using System.Diagnostics;
     using Microsoft.CodeAnalysis;
     using Microsoft.CodeAnalysis.CSharp.Syntax;
     using Microsoft.CodeAnalysis.Text;
 
-    [DebuggerDisplay("{this.Text}")]
     public struct Span : IEquatable<Span>
     {
         private readonly LiteralExpressionSyntax literal;
@@ -53,6 +51,11 @@ public override int GetHashCode()
             }
         }
 
+        public override string ToString()
+        {
+            return this.literal.Token.ValueText.Substring(this.TextSpan.Start, this.TextSpan.Length);
+        }
+
         public Location GetLocation() => GetLocation(this.literal, this.TextSpan);
 
         public Location GetLocation(int start, int length) => GetLocation(this.literal, new TextSpan(this.TextSpan.Start + start, length));