Fix warnings.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/Helpers/SpanTests.cs

@@ -57,7 +57,6 @@ class C
         [TestCase("\"abc\"", "bc",   true)]
         [TestCase("\"abc\"", "c",    true)]
         [TestCase("\"abc\"", "ab",   false)]
-        [TestCase("\"abc\"", "bc",   false)]
         [TestCase("\"abc\"", "dabc", false)]
         public void EndsWith(string text, string value, bool expected)
         {

AspNetCoreAnalyzers.Tests/Helpers/UrlTemplateTests.cs

@@ -64,7 +64,7 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
             var segment = template.Path.Single(x => x.Parameter.HasValue);
 
             Assert.AreEqual(expected.Single(x => x.StartsWith("{", StringComparison.Ordinal)), segment.Span.ToString());
-            Assert.AreEqual("id",                                                              segment.Parameter.Value.Name.ToString());
+            Assert.AreEqual("id", segment.Parameter?.Name.ToString());
         }
 
         [TestCase("\"orders/{id}\"",                   new[] { "orders", "{id}" },                   new string[0])]

AspNetCoreAnalyzers/CodeFixes/TemplateTextFix.cs

@@ -35,7 +35,8 @@ public override async Task RegisterCodeFixesAsync(CodeFixContext context)
                     context.RegisterCodeFix(
                         CodeAction.Create(
                             GetTitle(diagnostic),
-                            _ => Fix(_)),
+                            _ => Fix(_),
+                            equivalenceKey: null),
                         diagnostic);
 
                     async Task<Document> Fix(CancellationToken cancellationToken)

AspNetCoreAnalyzers/Helpers/Span.cs

@@ -127,7 +127,6 @@ internal bool EndsWith(string value, StringComparison comparisonType)
                 return this.Literal.ValueText.IndexOf(value, start, value.Length, comparisonType) == start;
             }
 
-
             return false;
         }
     }

AspNetCoreAnalyzers/Helpers/Text.cs

@@ -2,15 +2,6 @@ namespace AspNetCoreAnalyzers
 {
     public static class Text
     {
-        public static void SkipWhiteSpace(Span text, ref int pos)
-        {
-            while (pos < text.Length &&
-                   text[pos] == ' ')
-            {
-                pos++;
-            }
-        }
-
         public static void SkipWhiteSpace(string text, ref int pos)
         {
             while (pos < text.Length &&
@@ -56,15 +47,6 @@ public static bool TrySkipPast(string text, ref int pos, string substring)
             return false;
         }
 
-        public static void BackWhiteSpace(Span text, ref int pos)
-        {
-            while (pos >= 0 &&
-                   text[pos] == ' ')
-            {
-                pos--;
-            }
-        }
-
         private static bool IsAt(Span text, int pos, string substring)
         {
             for (var i = 0; i < substring.Length; i++)