Fix warnings.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP004RouteParameterTypeTests/Valid.cs

@@ -1,4 +1,4 @@
-namespace AspNetCoreAnalyzers.Tests.ASP004RouteParameterTypeTests
+namespace AspNetCoreAnalyzers.Tests.ASP004RouteParameterTypeTests
 {
     using Gu.Roslyn.Asserts;
     using Microsoft.CodeAnalysis.Diagnostics;

AspNetCoreAnalyzers.Tests/DocumentationTests.cs

@@ -1,4 +1,5 @@
 #pragma warning disable CA1056 // Uri properties should not be strings
+#pragma warning disable CA1305 // Specify IFormatProvider
 namespace AspNetCoreAnalyzers.Tests
 {
     using System;
@@ -309,7 +310,7 @@ public MarkdownFile(string name)
 
         public class CodeFile
         {
-            private static readonly ConcurrentDictionary<Type, CodeFile> Cache = new ConcurrentDictionary<Type, CodeFile>();
+            private static readonly ConcurrentDictionary<Type, CodeFile> Cache = new();
 
             public CodeFile(string name)
             {
@@ -318,8 +319,8 @@ public CodeFile(string name)
 
             public string Name { get; }
 
-            public string Uri => "https://github.com/DotNetAnalyzers/AspNetCoreAnalyzers/blob/master" + this.Name.Substring(SolutionDirectory.FullName.Length)
-                                                                                                             .Replace("\\", "/", StringComparison.Ordinal);
+            public string Uri => "https://github.com/DotNetAnalyzers/AspNetCoreAnalyzers/blob/master" + this.Name[SolutionDirectory.FullName.Length..]
+                                                                                                            .Replace("\\", "/", StringComparison.Ordinal);
 
             public static CodeFile Find(Type type)
             {

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -983,7 +983,7 @@ private static bool HasHttpVerbAttribute(MethodDeclarationSyntax methodDeclarati
             return false;
         }
 
-        private struct Replacement<T>
+        private readonly struct Replacement<T>
         {
             internal readonly T Node;
 
@@ -998,8 +998,8 @@ internal Replacement(T node, string? newText)
             internal ImmutableDictionary<string, string?> Property(string key)
             {
                 return this.NewText is { } value
-                    ? ImmutableDictionary<string, string>.Empty.Add(key, value)
-                    : ImmutableDictionary<string, string>.Empty;
+                    ? ImmutableDictionary<string, string?>.Empty.Add(key, value)
+                    : ImmutableDictionary<string, string?>.Empty;
             }
         }
     }

AspNetCoreAnalyzers/CodeFixes/RenameParameterFix.cs

@@ -40,8 +40,8 @@ semanticModel is { } &&
                             cancellationToken => Renamer.RenameSymbolAsync(
                                 context.Document.Project.Solution,
                                 parameter,
-                                name,
-                                null,
+                                name!,
+                                context.Document.Project.Solution.Options,
                                 cancellationToken),
                             nameof(RenameParameterFix)),
                         diagnostic);

AspNetCoreAnalyzers/CodeFixes/RenameTypeFix.cs

@@ -40,8 +40,8 @@ semanticModel is { } &&
                             cancellationToken => Renamer.RenameSymbolAsync(
                                 context.Document.Project.Solution,
                                 parameter,
-                                name,
-                                null,
+                                name!,
+                                context.Document.Project.Solution.Options,
                                 cancellationToken),
                             nameof(RenameParameterFix)),
                         diagnostic);

AspNetCoreAnalyzers/Helpers/KnownSymbols/KnownSymbol.cs

@@ -4,8 +4,8 @@
 
     internal static class KnownSymbol
     {
-        internal static readonly ObjectType Object = new ObjectType();
-        internal static readonly StringType String = new StringType();
+        internal static readonly ObjectType Object = new();
+        internal static readonly StringType String = new();
         internal static readonly QualifiedType Boolean = Create("System.Boolean", "bool");
         internal static readonly QualifiedType DateTime = Create("System.DateTime");
         internal static readonly QualifiedType Decimal = Create("System.Decimal", "decimal");

AspNetCoreAnalyzers/Helpers/KnownSymbols/ObjectType.cs

@@ -14,4 +14,4 @@ internal ObjectType()
             this.ReferenceEquals = new QualifiedMethod(this, nameof(this.ReferenceEquals));
         }
     }
-}
+}

AspNetCoreAnalyzers/Helpers/KnownSymbols/StringType.cs

@@ -14,4 +14,4 @@ internal StringType()
             this.Equals = new QualifiedMethod(this, nameof(this.Equals));
         }
     }
-}
+}