Check argument for min, mac, minlength & maxlength. #26

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/ASP004ParameterSyntaxTests/Diagnostics.cs

@@ -12,6 +12,10 @@ public class Diagnostics
         [TestCase("api/orders/{id:↓wrong}")]
         [TestCase("api/orders/{id:min1)}")]
         [TestCase("api/orders/{id:max1)}")]
+        [TestCase("api/orders/{id:min(↓wrong))}")]
+        [TestCase("api/orders/{id:max(↓wrong))}")]
+        [TestCase("api/orders/{id:minlength(↓wrong))}")]
+        [TestCase("api/orders/{id:maxlength(↓wrong))}")]
         [TestCase("api/orders/{id:↓:int)}")]
         [TestCase("api/orders/{id:int:↓)}")]
         [TestCase("api/orders/{id:int:↓:)}")]

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -241,6 +241,15 @@ private static bool HasWrongSyntax(PathSegment segment, out Location location, o
                         }
                     }
 
+                    if (HasWrongIntArgumentSyntax(constraint, "min", out location) ||
+                        HasWrongIntArgumentSyntax(constraint, "max", out location) ||
+                        HasWrongIntArgumentSyntax(constraint, "minlength", out location) ||
+                        HasWrongIntArgumentSyntax(constraint, "maxlength", out location))
+                    {
+                        correctSyntax = null;
+                        return true;
+                    }
+
                     if (!text.Equals("?", StringComparison.OrdinalIgnoreCase) &&
                         !text.Equals("int", StringComparison.OrdinalIgnoreCase) &&
                         !text.Equals("bool", StringComparison.OrdinalIgnoreCase) &&
@@ -286,10 +295,31 @@ private static bool HasWrongSyntax(PathSegment segment, out Location location, o
                 }
             }
 
-
             location = null;
             correctSyntax = null;
             return false;
+
+            bool HasWrongIntArgumentSyntax(RouteConstraint constraint, string methodName, out Location result)
+            {
+                var text = constraint.Span.Text;
+                if (text.Length > methodName.Length + 2 &&
+                    text.StartsWith(methodName, StringComparison.OrdinalIgnoreCase) &&
+                    text[methodName.Length] == '(' &&
+                    text[text.Length - 1] == ')')
+                {
+                    for (var i = methodName.Length + 1; i < text.Length - 2; i++)
+                    {
+                        if (!char.IsDigit(text[i]))
+                        {
+                            result = constraint.Span.GetLocation(i);
+                            return true;
+                        }
+                    }
+                }
+
+                result = null;
+                return false;
+            }
         }
     }
 }

AspNetCoreAnalyzers/Helpers/Span.cs

@@ -55,6 +55,8 @@ public override int GetHashCode()
 
         public Location GetLocation() => Location.Create(this.literal.SyntaxTree, new TextSpan(this.literal.SpanStart + this.TextSpan.Start + 1, this.TextSpan.Length));
 
+        public Location GetLocation(int start) => Location.Create(this.literal.SyntaxTree, new TextSpan(this.literal.SpanStart + this.TextSpan.Start + start + 1, this.TextSpan.Length));
+
         internal Span Slice(int start, int end)
         {
             if (start > end)