Fix warnings.

Author: JohanLarsson

AspNetCoreAnalyzers.Tests/DocumentationTests.cs

@@ -1,6 +1,4 @@
-#pragma warning disable CA1055 // Uri return values should not be strings
-#pragma warning disable CA1056 // Uri properties should not be strings
-#pragma warning disable CA1721 // Property names should not match get methods
+#pragma warning disable CA1056 // Uri properties should not be strings
 namespace AspNetCoreAnalyzers.Tests
 {
     using System;
@@ -228,7 +226,7 @@ private static string CreateStub(DiagnosticDescriptor descriptor)
 | Topic    | Value
 | :--      | :--
 | Id       | {descriptor.Id}
-| Severity | {descriptor.DefaultSeverity.ToString()}
+| Severity | {descriptor.DefaultSeverity}
 | Enabled  | {(descriptor.IsEnabledByDefault ? "True" : "False")}
 | Category | {descriptor.Category}
 | Code     | [<TYPENAME>](<URL>)

AspNetCoreAnalyzers.Tests/Helpers/UrlTemplateTests.cs

@@ -1,4 +1,4 @@
-namespace AspNetCoreAnalyzers.Tests.Helpers
+namespace AspNetCoreAnalyzers.Tests.Helpers
 {
     using System;
     using System.Linq;
@@ -32,7 +32,7 @@ public async Task<IActionResult> GetOrder([FromRoute]int id)
             var literal = syntaxTree.FindLiteralExpression(text);
             Assert.AreEqual(true, UrlTemplate.TryParse(literal, out var template));
             CollectionAssert.AreEqual(expected, template.Path.Select(x => x.Span.ToString()));
-            Assert.IsTrue(template.Path.All(x => x.Parameter == null));
+            Assert.IsTrue(template.Path.All(x => x.Parameter is null));
         }
 
         [TestCase("{id}",                 new[] { "{id}" })]

AspNetCoreAnalyzers/Analyzers/AttributeAnalyzer.cs

@@ -33,11 +33,6 @@ internal class AttributeAnalyzer : DiagnosticAnalyzer
 
         public override void Initialize(AnalysisContext context)
         {
-            if (context == null)
-            {
-                throw new ArgumentNullException(nameof(context));
-            }
-
             context.EnableConcurrentExecution();
             context.ConfigureGeneratedCodeAnalysis(GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics);
             context.RegisterSyntaxNodeAction(c => Handle(c), SyntaxKind.Attribute);
@@ -494,7 +489,7 @@ private static bool HasWrongSyntax(PathSegment segment, out Replacement<Span> re
             replacement = default;
             return false;
 
-            bool HasWrongIntArgumentSyntax(RouteConstraint constraint, string methodName, out Span result)
+            static bool HasWrongIntArgumentSyntax(RouteConstraint constraint, string methodName, out Span result)
             {
                 var text = constraint.Span;
                 if (text.Length > methodName.Length + 2 &&
@@ -519,7 +514,7 @@ bool HasWrongIntArgumentSyntax(RouteConstraint constraint, string methodName, ou
 
         private static bool HasWrongRegexSyntax(PathSegment segment, out Replacement<Span> replacement)
         {
-            if (segment.Parameter is TemplateParameter parameter)
+            if (segment.Parameter is { } parameter)
             {
                 foreach (var constraint in parameter.Constraints)
                 {
@@ -648,7 +643,7 @@ private static bool HasInvalidName(PathSegment segment, out Replacement<Span> re
 
         private static bool ShouldKebabCase(PathSegment segment, [NotNullWhen(true)] out string? kebabCase)
         {
-            if (segment.Parameter == null &&
+            if (segment is { Parameter: null } &&
                 IsHumpOrSnakeCased(segment.Span))
             {
                 kebabCase = KebabCase(segment.Span.ToString());
@@ -658,7 +653,7 @@ private static bool ShouldKebabCase(PathSegment segment, [NotNullWhen(true)] out
             kebabCase = null;
             return false;
 
-            bool IsHumpOrSnakeCased(Span span)
+            static bool IsHumpOrSnakeCased(Span span)
             {
                 for (var i = 0; i < span.Length; i++)
                 {
@@ -707,7 +702,7 @@ private static string KebabCase(string text)
         /// </summary>
         private static bool HasSyntaxError(PathSegment segment, [NotNullWhen(true)] out Location? location)
         {
-            if (segment.Parameter == null)
+            if (segment.Parameter is null)
             {
                 for (var i = 0; i < segment.Span.Length; i++)
                 {
@@ -732,8 +727,8 @@ private static bool HasSyntaxError(PathSegment segment, [NotNullWhen(true)] out
 
         private static bool IsMultipleOccurringParameter(PathSegment segment, UrlAttribute urlAttribute, SyntaxNodeAnalysisContext context, [NotNullWhen(true)] out Location? location)
         {
-            if (segment.Parameter is TemplateParameter parameter &&
-                urlAttribute.UrlTemplate is UrlTemplate template)
+            if (segment.Parameter is { } parameter &&
+                urlAttribute.UrlTemplate is { } template)
             {
                 if (ContainsName(template.Path))
                 {
@@ -743,8 +738,7 @@ private static bool IsMultipleOccurringParameter(PathSegment segment, UrlAttribu
 
                 if (urlAttribute.TryGetParentMember(out var parentMember))
                 {
-                    if (parentMember is MethodDeclarationSyntax parentMethod &&
-                        parentMethod.Parent is ClassDeclarationSyntax classDeclaration &&
+                    if (parentMember is MethodDeclarationSyntax { Parent: ClassDeclarationSyntax classDeclaration } &&
                         TryGetOtherTemplate(classDeclaration.AttributeLists, out var otherTemplate) &&
                         ContainsName(otherTemplate.Path))
                     {
@@ -822,7 +816,7 @@ private static bool ShouldUseExplicitRoute(PathSegment segment, SyntaxNodeAnalys
         private static bool ShouldRenameController(PathSegment segment, UrlAttribute urlAttribute, SyntaxNodeAnalysisContext context, out Replacement<Location> replacement)
         {
             if (urlAttribute.UrlTemplate is { } template &&
-                template.Path.TryLast(x => x.Parameter == null, out var last) &&
+                template.Path.TryLast(x => x.Parameter is null, out var last) &&
                 last == segment &&
                 segment.Span.Length > 0 &&
                 segment.Span[0] != '[' &&
@@ -945,7 +939,7 @@ private static bool TryFindParameter(TemplateParameter templateParameter, Method
             result = null;
             return false;
 
-            bool IsFromRoute(ParameterSyntax p)
+            static bool IsFromRoute(ParameterSyntax p)
             {
                 foreach (var attributeList in p.AttributeLists)
                 {

AspNetCoreAnalyzers/Helpers/UrlAttribute.cs

@@ -76,8 +76,7 @@ argument.Expression is LiteralExpressionSyntax literal &&
 
         internal bool TryGetParentMember(out MemberDeclarationSyntax memberDeclaration)
         {
-            if (this.Attribute.Parent is AttributeListSyntax attributeList &&
-                attributeList.Parent is MemberDeclarationSyntax temp)
+            if (this.Attribute.Parent is AttributeListSyntax { Parent: MemberDeclarationSyntax temp })
             {
                 memberDeclaration = temp;
                 return true;

ValidCode/.editorconfig

@@ -15,4 +15,7 @@ dotnet_diagnostic.CS8618.severity = none
 # Default severity for analyzer diagnostics with category 'StyleCop.CSharp.DocumentationRules'
 dotnet_analyzer_diagnostic.category-StyleCop.CSharp.DocumentationRules.severity = none
 # SA0001: XML comment analysis is disabled due to project configuration
-dotnet_diagnostic.SA0001.severity = none
+dotnet_diagnostic.SA0001.severity = none
+
+# IDE0079: Remove unnecessary suppression
+dotnet_diagnostic.IDE0079.severity = none