Skip to content

Commit e804d7c

Browse files
committed
WIP
1 parent 47730f9 commit e804d7c

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

AspNetCoreAnalyzers.Tests/ASP004ParameterSyntaxTests/Diagnostics.cs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,10 @@ public IActionResult GetId(long id)
3838
AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
3939
}
4040

41-
[TestCase("api/orders/{id:minlength(↓wrong))}")]
42-
[TestCase("api/orders/{id:maxlength(↓wrong))}")]
41+
[TestCase("\"api/orders/{id:regex(\\\\d):minlength(↓wrong))}\"")]
42+
[TestCase("@\"api/orders/{id:regex(\\d):minlength(↓wrong))}\"")]
43+
[TestCase("\"api/orders/{id:minlength(↓wrong))}\"")]
44+
[TestCase("\"api/orders/{id:maxlength(↓wrong))}\"")]
4345
public void WhenString(string before)
4446
{
4547
var code = @"
@@ -56,7 +58,7 @@ public IActionResult GetId(string id)
5658
return this.Ok(id);
5759
}
5860
}
59-
}".AssertReplace("api/orders/↓{id:wrong}", before);
61+
}".AssertReplace("\"api/orders/↓{id:wrong}\"", before);
6062

6163
AnalyzerAssert.Diagnostics(Analyzer, ExpectedDiagnostic, code);
6264
}

AspNetCoreAnalyzers.Tests/ASP005ParameterRegexTests/CodeFix.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,11 @@ public class CodeFix
1111
private static readonly ExpectedDiagnostic ExpectedDiagnostic = ExpectedDiagnostic.Create(ASP005ParameterRegex.Descriptor);
1212
private static readonly CodeFixProvider Fix = new TemplateTextFix();
1313

14-
[TestCase("api/orders/{id:regex(↓a{1})}", "api/orders/{id:regex(a{{1}})}")]
15-
[TestCase("api/orders/{id:regex(↓^[a-z]{2}$)}", "api/orders/{id:regex(^[[a-z]]{{2}}$)}")]
14+
[TestCase("\"api/orders/{id:regex(↓a{1})}\"", "\"api/orders/{id:regex(a{{1}})}\"")]
15+
[TestCase("\"api/orders/{id:regex(↓\\\\d+)}", "\"api/orders/{id:regex(\\\\\\\\d+)}\"")]
16+
[TestCase("@\"api/orders/{id:regex(↓\\d+)}", "@\"api/orders/{id:regex(\\\\d+)}\"")]
17+
[TestCase("\"api/orders/{id:regex(↓^\\\\d{3}-\\\\d{2}-\\\\d{4}$)}", "\"api/orders/{id:regex(^\\\\d{{3}}-\\\\d{{2}}-\\\\d{{4}}$)}\"")]
18+
[TestCase("\"api/orders/{id:regex(↓^[a-z]{2}$)}\"", "\"api/orders/{id:regex(^[[a-z]]{{2}}$)}\"")]
1619
public void When(string before, string after)
1720
{
1821
var code = @"
@@ -29,7 +32,7 @@ public IActionResult GetId(string id)
2932
return this.Ok(id);
3033
}
3134
}
32-
}".AssertReplace("api/orders/{id}", before);
35+
}".AssertReplace("\"api/orders/{id}\"", before);
3336

3437
var fixedCode = @"
3538
namespace ValidCode
@@ -45,7 +48,7 @@ public IActionResult GetId(string id)
4548
return this.Ok(id);
4649
}
4750
}
48-
}".AssertReplace("api/orders/{id}", after);
51+
}".AssertReplace("\"api/orders/{id}\"", after);
4952
AnalyzerAssert.CodeFix(Analyzer, Fix, ExpectedDiagnostic, code, fixedCode);
5053
}
5154
}

0 commit comments

Comments
 (0)